From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD420C433E0 for ; Tue, 7 Jul 2020 19:26:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABFF2206E9 for ; Tue, 7 Jul 2020 19:26:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594149976; bh=uxcMM/Sf9inJLIkj1U8e0LfZX/0p8ULXiZ2yN0bNMnc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=YKhWRCbkjo3U5S5badC4HW22Gd3EM1F0RLByOaHe8Faihjk5UzSi6lO3+Ba50uN3d oDVfeAA0xrMuYc5ANyzaWCJ5tW0vmq+5C2e22jVEDtnv+iek9/KmjNUsfSP+dIF1vw 1+qNui/R5VSt2p+05mBO+mMQanyGRKesYuYVJuFU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728562AbgGGT0N (ORCPT ); Tue, 7 Jul 2020 15:26:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:45392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728100AbgGGT0N (ORCPT ); Tue, 7 Jul 2020 15:26:13 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 66EB4206BE; Tue, 7 Jul 2020 19:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594149972; bh=uxcMM/Sf9inJLIkj1U8e0LfZX/0p8ULXiZ2yN0bNMnc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OZ9oxJPKMjuAxAmKeMAMKFymbhEyjmXIECfqDtlfmvgSF4TgxNY9YLFoNZb2hIrPd gSeBgN0IW5+L1EdPdkdCwjTulvRa1gyxwU0fX8CJRmFSwYpz0k85UyPielx4nyddEa CWRf3xdhMMl7uifSsvzoml6r7C6cp901pUmd8EQY= Date: Tue, 7 Jul 2020 12:26:12 -0700 From: Andrew Morton To: Eric Biggers Cc: linux-fsdevel@vger.kernel.org, Alexander Viro , linux-kernel@vger.kernel.org, Qiujun Huang , stable@vger.kernel.org, syzbot+4a88b2b9dc280f47baf4@syzkaller.appspotmail.com Subject: Re: [PATCH 1/6] fs/minix: check return value of sb_getblk() Message-Id: <20200707122612.249699c3f136968dd6782452@linux-foundation.org> In-Reply-To: <20200628060846.682158-2-ebiggers@kernel.org> References: <20200628060846.682158-1-ebiggers@kernel.org> <20200628060846.682158-2-ebiggers@kernel.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sat, 27 Jun 2020 23:08:40 -0700 Eric Biggers wrote: > From: Eric Biggers > > sb_getblk() can fail, so check its return value. > > This fixes a NULL pointer dereference. > > Reported-by: syzbot+4a88b2b9dc280f47baf4@syzkaller.appspotmail.com > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Cc: stable@vger.kernel.org > Originally-from: Qiujun Huang Originally-from: isn't really a thing. Did the original come with a signed-off-by:? > Signed-off-by: Eric Biggers > > ... >