From: Eric Biggers <ebiggers@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] fs: define inode flags using bit numbers
Date: Mon, 13 Jul 2020 09:02:59 -0700 [thread overview]
Message-ID: <20200713160259.GB1696@sol.localdomain> (raw)
In-Reply-To: <20200713115947.GX12769@casper.infradead.org>
On Mon, Jul 13, 2020 at 12:59:47PM +0100, Matthew Wilcox wrote:
> On Sun, Jul 12, 2020 at 08:09:52PM -0700, Eric Biggers wrote:
> > Define the VFS inode flags using bit numbers instead of hardcoding
> > powers of 2, which has become unwieldy now that we're up to 65536.
>
> If you're going to change these, why not use the BIT() macro?
>
Either way would be fine with me, but I've seen people complain about BIT()
before and say they prefer just (1 << n).
- Eric
next prev parent reply other threads:[~2020-07-13 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 3:09 [PATCH] fs: define inode flags using bit numbers Eric Biggers
2020-07-13 11:59 ` Matthew Wilcox
2020-07-13 16:02 ` Eric Biggers [this message]
2020-07-14 1:18 ` Dave Chinner
2020-07-27 16:48 ` Eric Biggers
2020-07-27 18:38 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713160259.GB1696@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).