From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
"hch@infradead.org" <hch@infradead.org>,
Christoph Hellwig <hch@lst.de>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH 2/2] zonefs: use zone-append for AIO as well
Date: Wed, 22 Jul 2020 16:53:01 +0200 [thread overview]
Message-ID: <20200722145301.GB20266@lst.de> (raw)
In-Reply-To: <CY4PR04MB375139CC436B04DDE02B8560E7790@CY4PR04MB3751.namprd04.prod.outlook.com>
On Wed, Jul 22, 2020 at 01:02:14PM +0000, Damien Le Moal wrote:
> That is the general idea. But Christoph point was that reporting the effective
> write offset back to user space can be done not only for zone append, but also
> for regular FS/files that are open with O_APPEND and being written with AIOs,
> legacy or io_uring. Since for this case, the aio->aio_offset field is ignored
> and the kiocb pos is initialized with the file size, then incremented with size
> for the next AIO, the user never actually sees the actual write offset of its
> AIOs. Reporting that back for regular files too can be useful, even though
> current application can do without this (or do not use O_APPEND because it is
> lacking).
>
> Christoph, please loudly shout at me if I misunderstood you :)
I'd never shout at you :) But yes, this is correct.
next prev parent reply other threads:[~2020-07-22 14:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 13:21 [PATCH 0/2] zonefs: use zone-append for aio with rwf append Johannes Thumshirn
2020-07-20 13:21 ` [PATCH 1/2] fs: fix kiocb ki_complete interface Johannes Thumshirn
2020-07-20 13:38 ` Christoph Hellwig
2020-07-20 13:43 ` Damien Le Moal
2020-07-20 13:47 ` Christoph Hellwig
2020-07-20 13:21 ` [PATCH 2/2] zonefs: use zone-append for AIO as well Johannes Thumshirn
2020-07-20 13:45 ` Christoph Hellwig
2020-07-20 16:48 ` Johannes Thumshirn
2020-07-21 5:54 ` Christoph Hellwig
2020-07-22 12:43 ` Johannes Thumshirn
2020-07-22 13:02 ` Damien Le Moal
2020-07-22 14:53 ` Christoph Hellwig [this message]
2020-07-22 14:51 ` Christoph Hellwig
2020-07-22 15:00 ` Johannes Thumshirn
2020-07-24 13:57 ` Kanchan Joshi
2020-07-27 3:12 ` Damien Le Moal
2020-07-21 12:43 ` Kanchan Joshi
2020-07-22 14:32 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722145301.GB20266@lst.de \
--to=hch@lst.de \
--cc=Damien.LeMoal@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).