From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F2A3C433EC for ; Sun, 26 Jul 2020 15:18:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E36012065F for ; Sun, 26 Jul 2020 15:18:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="STtIccUJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726801AbgGZPSZ (ORCPT ); Sun, 26 Jul 2020 11:18:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725982AbgGZPSZ (ORCPT ); Sun, 26 Jul 2020 11:18:25 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB69BC0619D2; Sun, 26 Jul 2020 08:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=khbJGT4iiSr5u+iKgwn7bl9+62UCe+CYOlUWfazTxPM=; b=STtIccUJbrGHRgBJdhNTayz1Ld ljv3MsUoYDsnK8KLZQFsoDnj6ZI7DzwasiQPTfoO9qzR6ViwsCgKrP566P9Ckq3JaJteeiknLstel N2djokW45aiJ75/ZtjAF3dBac/ckrf+MdlBZ/LWWMr9ft3tndvJG5LkG+ITi/fX06N4UlOX/EY1SM l7HYYllyigDLLipFkUIQ48f46/OE08cV4ze3kiWNXcoq6fRZDQj1y1mwx0v5Ya7veVhxM2GxFUWST OHl1fbiMjdeZNkplTIn2JWt+leI8Ry1ze0Ee7N0H28GXr1EeFAp2blNGoopSuWuStZoZMvmML0VP7 nj/IZIEA==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jziPr-0006f6-2o; Sun, 26 Jul 2020 15:18:19 +0000 Date: Sun, 26 Jul 2020 16:18:19 +0100 From: Christoph Hellwig To: Kanchan Joshi Cc: axboe@kernel.dk, viro@zeniv.linux.org.uk, bcrl@kvack.org, willy@infradead.org, hch@infradead.org, Damien.LeMoal@wdc.com, asml.silence@gmail.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-aio@kvack.org, io-uring@vger.kernel.org, linux-block@vger.kernel.org, linux-api@vger.kernel.org, SelvaKumar S , Nitesh Shetty , Javier Gonzalez Subject: Re: [PATCH v4 2/6] fs: change ki_complete interface to support 64bit ret2 Message-ID: <20200726151819.GB25328@infradead.org> References: <1595605762-17010-1-git-send-email-joshi.k@samsung.com> <1595605762-17010-3-git-send-email-joshi.k@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1595605762-17010-3-git-send-email-joshi.k@samsung.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Jul 24, 2020 at 09:19:18PM +0530, Kanchan Joshi wrote: > From: SelvaKumar S > > kiocb->ki_complete(...,long ret2) - change ret2 to long long. > This becomes handy to return 64bit written-offset with appending write. > Change callers using ki_complete prototype. There is no need for this at all. By the time ki_complete is called ki_pos contains the new offset, and you just have to subtract res from that.