From: kernel test robot <lkp@intel.com>
To: Xi Wang <xii@google.com>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: kbuild-all@lists.01.org, Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Mel Gorman <mgorman@suse.de>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Xi Wang <xii@google.com>
Subject: Re: [PATCH] sched: Make select_idle_sibling search domain configurable
Date: Tue, 28 Jul 2020 18:00:31 +0800 [thread overview]
Message-ID: <202007281716.JUok2FkW%lkp@intel.com> (raw)
In-Reply-To: <20200728070131.1629670-1-xii@google.com>
[-- Attachment #1: Type: text/plain, Size: 10911 bytes --]
Hi Xi,
I love your patch! Yet something to improve:
[auto build test ERROR on tip/sched/core]
[also build test ERROR on tip/auto-latest linus/master v5.8-rc7]
[cannot apply to block/for-next cgroup/for-next next-20200727]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Xi-Wang/sched-Make-select_idle_sibling-search-domain-configurable/20200728-150328
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 13efa616124f7eec7d6a58adeeef31864aa03879
config: nios2-defconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from kernel/kthread.c:20:
include/linux/cpuset.h: In function 'cpuset_update_active_cpus':
>> include/linux/cpuset.h:177:2: error: too many arguments to function 'partition_sched_domains'
177 | partition_sched_domains(1, NULL, NULL, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/cpuset.h:13,
from kernel/kthread.c:20:
include/linux/sched/topology.h:208:1: note: declared here
208 | partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[],
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/kthread.c:20:
include/linux/cpuset.h: In function 'rebuild_sched_domains':
include/linux/cpuset.h:263:2: error: too many arguments to function 'partition_sched_domains'
263 | partition_sched_domains(1, NULL, NULL, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/cpuset.h:13,
from kernel/kthread.c:20:
include/linux/sched/topology.h:208:1: note: declared here
208 | partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[],
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/kthread.c:20:
include/linux/cpuset.h: In function 'rebuild_sched_domains_force':
include/linux/cpuset.h:268:2: error: too many arguments to function 'partition_sched_domains'
268 | partition_sched_domains(1, NULL, NULL, 1);
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/cpuset.h:13,
from kernel/kthread.c:20:
include/linux/sched/topology.h:208:1: note: declared here
208 | partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[],
| ^~~~~~~~~~~~~~~~~~~~~~~
--
In file included from kernel/sched/sched.h:44,
from kernel/sched/core.c:13:
include/linux/cpuset.h: In function 'cpuset_update_active_cpus':
>> include/linux/cpuset.h:177:2: error: too many arguments to function 'partition_sched_domains'
177 | partition_sched_domains(1, NULL, NULL, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/sched/sched.h:31,
from kernel/sched/core.c:13:
include/linux/sched/topology.h:208:1: note: declared here
208 | partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[],
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/sched/sched.h:44,
from kernel/sched/core.c:13:
include/linux/cpuset.h: In function 'rebuild_sched_domains':
include/linux/cpuset.h:263:2: error: too many arguments to function 'partition_sched_domains'
263 | partition_sched_domains(1, NULL, NULL, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/sched/sched.h:31,
from kernel/sched/core.c:13:
include/linux/sched/topology.h:208:1: note: declared here
208 | partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[],
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/sched/sched.h:44,
from kernel/sched/core.c:13:
include/linux/cpuset.h: In function 'rebuild_sched_domains_force':
include/linux/cpuset.h:268:2: error: too many arguments to function 'partition_sched_domains'
268 | partition_sched_domains(1, NULL, NULL, 1);
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/sched/sched.h:31,
from kernel/sched/core.c:13:
include/linux/sched/topology.h:208:1: note: declared here
208 | partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[],
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/core.c: In function 'ttwu_stat':
kernel/sched/core.c:2319:13: warning: variable 'rq' set but not used [-Wunused-but-set-variable]
2319 | struct rq *rq;
| ^~
--
In file included from kernel/sched/sched.h:44,
from kernel/sched/fair.c:23:
include/linux/cpuset.h: In function 'cpuset_update_active_cpus':
>> include/linux/cpuset.h:177:2: error: too many arguments to function 'partition_sched_domains'
177 | partition_sched_domains(1, NULL, NULL, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/sched/sched.h:31,
from kernel/sched/fair.c:23:
include/linux/sched/topology.h:208:1: note: declared here
208 | partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[],
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/sched/sched.h:44,
from kernel/sched/fair.c:23:
include/linux/cpuset.h: In function 'rebuild_sched_domains':
include/linux/cpuset.h:263:2: error: too many arguments to function 'partition_sched_domains'
263 | partition_sched_domains(1, NULL, NULL, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/sched/sched.h:31,
from kernel/sched/fair.c:23:
include/linux/sched/topology.h:208:1: note: declared here
208 | partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[],
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/sched/sched.h:44,
from kernel/sched/fair.c:23:
include/linux/cpuset.h: In function 'rebuild_sched_domains_force':
include/linux/cpuset.h:268:2: error: too many arguments to function 'partition_sched_domains'
268 | partition_sched_domains(1, NULL, NULL, 1);
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/sched/sched.h:31,
from kernel/sched/fair.c:23:
include/linux/sched/topology.h:208:1: note: declared here
208 | partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[],
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c: At top level:
kernel/sched/fair.c:5364:6: warning: no previous prototype for 'init_cfs_bandwidth' [-Wmissing-prototypes]
5364 | void init_cfs_bandwidth(struct cfs_bandwidth *cfs_b) {}
| ^~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11165:6: warning: no previous prototype for 'free_fair_sched_group' [-Wmissing-prototypes]
11165 | void free_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11167:5: warning: no previous prototype for 'alloc_fair_sched_group' [-Wmissing-prototypes]
11167 | int alloc_fair_sched_group(struct task_group *tg, struct task_group *parent)
| ^~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11172:6: warning: no previous prototype for 'online_fair_sched_group' [-Wmissing-prototypes]
11172 | void online_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c:11174:6: warning: no previous prototype for 'unregister_fair_sched_group' [-Wmissing-prototypes]
11174 | void unregister_fair_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
--
In file included from kernel/sched/sched.h:44,
from kernel/sched/rt.c:6:
include/linux/cpuset.h: In function 'cpuset_update_active_cpus':
>> include/linux/cpuset.h:177:2: error: too many arguments to function 'partition_sched_domains'
177 | partition_sched_domains(1, NULL, NULL, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/sched/sched.h:31,
from kernel/sched/rt.c:6:
include/linux/sched/topology.h:208:1: note: declared here
208 | partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[],
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/sched/sched.h:44,
from kernel/sched/rt.c:6:
include/linux/cpuset.h: In function 'rebuild_sched_domains':
include/linux/cpuset.h:263:2: error: too many arguments to function 'partition_sched_domains'
263 | partition_sched_domains(1, NULL, NULL, 0);
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/sched/sched.h:31,
from kernel/sched/rt.c:6:
include/linux/sched/topology.h:208:1: note: declared here
208 | partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[],
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/sched/sched.h:44,
from kernel/sched/rt.c:6:
include/linux/cpuset.h: In function 'rebuild_sched_domains_force':
include/linux/cpuset.h:268:2: error: too many arguments to function 'partition_sched_domains'
268 | partition_sched_domains(1, NULL, NULL, 1);
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from kernel/sched/sched.h:31,
from kernel/sched/rt.c:6:
include/linux/sched/topology.h:208:1: note: declared here
208 | partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[],
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/rt.c: At top level:
kernel/sched/rt.c:253:6: warning: no previous prototype for 'free_rt_sched_group' [-Wmissing-prototypes]
253 | void free_rt_sched_group(struct task_group *tg) { }
| ^~~~~~~~~~~~~~~~~~~
kernel/sched/rt.c:255:5: warning: no previous prototype for 'alloc_rt_sched_group' [-Wmissing-prototypes]
255 | int alloc_rt_sched_group(struct task_group *tg, struct task_group *parent)
| ^~~~~~~~~~~~~~~~~~~~
kernel/sched/rt.c:668:6: warning: no previous prototype for 'sched_rt_bandwidth_account' [-Wmissing-prototypes]
668 | bool sched_rt_bandwidth_account(struct rt_rq *rt_rq)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/partition_sched_domains +177 include/linux/cpuset.h
174
175 static inline void cpuset_update_active_cpus(void)
176 {
> 177 partition_sched_domains(1, NULL, NULL, 0);
178 }
179
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 9871 bytes --]
next prev parent reply other threads:[~2020-07-28 10:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 7:01 [PATCH] sched: Make select_idle_sibling search domain configurable Xi Wang
2020-07-28 10:00 ` kernel test robot [this message]
2020-07-28 10:02 ` kernel test robot
2020-07-28 10:39 ` peterz
2020-07-28 17:54 ` Xi Wang
2020-08-03 22:38 ` Xi Wang
2020-08-04 1:19 ` kernel test robot
2020-08-04 1:19 ` [RFC PATCH] sched: __rebuild_sched_domains() can be static kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202007281716.JUok2FkW%lkp@intel.com \
--to=lkp@intel.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=xii@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).