From: "hch@infradead.org" <hch@infradead.org>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: Kanchan Joshi <joshiiitr@gmail.com>,
"hch@infradead.org" <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
Pavel Begunkov <asml.silence@gmail.com>,
Kanchan Joshi <joshi.k@samsung.com>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"bcrl@kvack.org" <bcrl@kvack.org>,
Matthew Wilcox <willy@infradead.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-aio@kvack.org" <linux-aio@kvack.org>,
"io-uring@vger.kernel.org" <io-uring@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
SelvaKumar S <selvakuma.s1@samsung.com>,
Nitesh Shetty <nj.shetty@samsung.com>,
Javier Gonzalez <javier.gonz@samsung.com>,
Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Subject: Re: [PATCH v4 6/6] io_uring: add support for zone-append
Date: Fri, 31 Jul 2020 10:14:16 +0100 [thread overview]
Message-ID: <20200731091416.GA29634@infradead.org> (raw)
In-Reply-To: <MWHPR04MB375863C20C1EF2CB27E62703E74E0@MWHPR04MB3758.namprd04.prod.outlook.com>
On Fri, Jul 31, 2020 at 08:14:22AM +0000, Damien Le Moal wrote:
>
> > This was one of the reason why we chose to isolate the operation by a
> > different IOCB flag and not by IOCB_APPEND alone.
>
> For zonefs, the plan is:
> * For the sync write case, zone append is always used.
> * For the async write case, if we see IOCB_APPEND, then zone append BIOs are
> used. If not, regular write BIOs are used.
>
> Simple enough I think. No need for a new flag.
Simple, but wrong. Sync vs async really doesn't matter, even sync
writes will have problems if there are other writers. We need a flag
for "report the actual offset for appending writes", and based on that
flag we need to not allow short writes (or split extents for real
file systems). We also need a fcntl or ioctl to report this max atomic
write size so that applications can rely on it.
next prev parent reply other threads:[~2020-07-31 9:14 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200724155244epcas5p2902f57e36e490ee8772da19aa9408cdc@epcas5p2.samsung.com>
2020-07-24 15:49 ` [PATCH v4 0/6] zone-append support in io-uring and aio Kanchan Joshi
[not found] ` <CGME20200724155258epcas5p1a75b926950a18cd1e6c8e7a047e6c589@epcas5p1.samsung.com>
2020-07-24 15:49 ` [PATCH v4 1/6] fs: introduce FMODE_ZONE_APPEND and IOCB_ZONE_APPEND Kanchan Joshi
2020-07-24 16:34 ` Jens Axboe
2020-07-26 15:18 ` Christoph Hellwig
2020-07-28 1:49 ` Matthew Wilcox
2020-07-28 7:26 ` Christoph Hellwig
[not found] ` <CGME20200724155324epcas5p18e1d3b4402d1e4a8eca87d0b56a3fa9b@epcas5p1.samsung.com>
2020-07-24 15:49 ` [PATCH v4 2/6] fs: change ki_complete interface to support 64bit ret2 Kanchan Joshi
2020-07-26 15:18 ` Christoph Hellwig
[not found] ` <CGME20200724155329epcas5p345ba6bad0b8fe18056bb4bcd26c10019@epcas5p3.samsung.com>
2020-07-24 15:49 ` [PATCH v4 3/6] uio: return status with iov truncation Kanchan Joshi
[not found] ` <CGME20200724155341epcas5p15bfc55927f2abb60f19784270fe8e377@epcas5p1.samsung.com>
2020-07-24 15:49 ` [PATCH v4 4/6] block: add zone append handling for direct I/O path Kanchan Joshi
2020-07-26 15:19 ` Christoph Hellwig
[not found] ` <CGME20200724155346epcas5p2cfb383fe9904a45280c6145f4c13e1b4@epcas5p2.samsung.com>
2020-07-24 15:49 ` [PATCH v4 5/6] block: enable zone-append for iov_iter of bvec type Kanchan Joshi
2020-07-26 15:20 ` Christoph Hellwig
[not found] ` <CGME20200724155350epcas5p3b8f1d59eda7f8fbb38c828f692d42fd6@epcas5p3.samsung.com>
2020-07-24 15:49 ` [PATCH v4 6/6] io_uring: add support for zone-append Kanchan Joshi
2020-07-24 16:29 ` Jens Axboe
2020-07-27 19:16 ` Kanchan Joshi
2020-07-27 20:34 ` Jens Axboe
2020-07-30 16:08 ` Pavel Begunkov
2020-07-30 16:13 ` Jens Axboe
2020-07-30 16:26 ` Pavel Begunkov
2020-07-30 17:16 ` Jens Axboe
2020-07-30 17:38 ` Pavel Begunkov
2020-07-30 17:51 ` Kanchan Joshi
2020-07-30 17:54 ` Jens Axboe
2020-07-30 18:25 ` Kanchan Joshi
2020-07-31 6:42 ` Damien Le Moal
2020-07-31 6:45 ` hch
2020-07-31 6:59 ` Damien Le Moal
2020-07-31 7:58 ` Kanchan Joshi
2020-07-31 8:14 ` Damien Le Moal
2020-07-31 9:14 ` hch [this message]
2020-07-31 9:34 ` Damien Le Moal
2020-07-31 9:41 ` hch
2020-07-31 10:16 ` Damien Le Moal
2020-07-31 12:51 ` hch
2020-07-31 13:08 ` hch
2020-07-31 15:07 ` Kanchan Joshi
2022-03-02 20:47 ` Luis Chamberlain
2020-08-05 7:35 ` Damien Le Moal
2020-08-14 8:14 ` hch
2020-08-14 8:27 ` Damien Le Moal
2020-08-14 12:04 ` hch
2020-08-14 12:20 ` Damien Le Moal
2020-09-07 7:01 ` Kanchan Joshi
2020-09-08 15:18 ` hch
2020-09-24 17:19 ` Kanchan Joshi
2020-09-25 2:52 ` Damien Le Moal
2020-09-28 18:58 ` Kanchan Joshi
2020-09-29 1:24 ` Damien Le Moal
2020-09-29 18:49 ` Kanchan Joshi
2022-03-02 20:43 ` Luis Chamberlain
2020-07-31 9:38 ` Kanchan Joshi
2022-03-02 20:51 ` Luis Chamberlain
2020-07-31 7:08 ` Kanchan Joshi
2020-07-30 15:57 ` Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731091416.GA29634@infradead.org \
--to=hch@infradead.org \
--cc=Damien.LeMoal@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=bcrl@kvack.org \
--cc=io-uring@vger.kernel.org \
--cc=javier.gonz@samsung.com \
--cc=joshi.k@samsung.com \
--cc=joshiiitr@gmail.com \
--cc=linux-aio@kvack.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nj.shetty@samsung.com \
--cc=selvakuma.s1@samsung.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).