From: Chris Kennelly <ckennelly@google.com>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
Alexey Dobriyan <adobriyan@gmail.com>,
Song Liu <songliubraving@fb.com>
Cc: David Rientjes <rientjes@google.com>,
Ian Rogers <irogers@google.com>, Hugh Dickens <hughd@google.com>,
Andrew Morton <akpm@google.com>,
Suren Baghdasaryan <surenb@google.com>,
Sandeep Patil <sspatil@google.com>,
Fangrui Song <maskray@google.com>,
Nick Desaulniers <ndesaulniers@google.com>,
clang-built-linux@googlegroups.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Chris Kennelly <ckennelly@google.com>
Subject: [PATCH 0/2 v2] Selecting Load Addresses According to p_align
Date: Fri, 31 Jul 2020 14:37:42 -0400 [thread overview]
Message-ID: <20200731183745.1669355-1-ckennelly@google.com> (raw)
The current ELF loading mechancism provides page-aligned mappings. This
can lead to the program being loaded in a way unsuitable for
file-backed, transparent huge pages when handling PIE executables.
While specifying -z,max-page-size=0x200000 to the linker will generate
suitably aligned segments for huge pages on x86_64, the executable needs
to be loaded at a suitably aligned address as well. This alignment
requires the binary's cooperation, as distinct segments need to be
appropriately paddded to be eligible for THP.
For binaries built with increased alignment, this limits the number of
bits usable for ASLR, but provides some randomization over using fixed
load addresses/non-PIE binaries.
Changes V1 -> V2:
* Added test
Chris Kennelly (2):
fs/binfmt_elf: Use PT_LOAD p_align values for suitable start address.
Add self-test for verifying load alignment.
fs/binfmt_elf.c | 24 ++++++++
tools/testing/selftests/exec/.gitignore | 1 +
tools/testing/selftests/exec/Makefile | 9 ++-
tools/testing/selftests/exec/load_address.c | 68 +++++++++++++++++++++
4 files changed, 100 insertions(+), 2 deletions(-)
create mode 100644 tools/testing/selftests/exec/load_address.c
--
2.28.0.163.g6104cc2f0b6-goog
next reply other threads:[~2020-07-31 18:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 18:37 Chris Kennelly [this message]
2020-07-31 18:37 ` [PATCH 1/2 v2] fs/binfmt_elf: Use PT_LOAD p_align values for suitable start address Chris Kennelly
2020-07-31 18:37 ` [PATCH 2/2 v2] Add self-test for verifying load alignment Chris Kennelly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731183745.1669355-1-ckennelly@google.com \
--to=ckennelly@google.com \
--cc=adobriyan@gmail.com \
--cc=akpm@google.com \
--cc=clang-built-linux@googlegroups.com \
--cc=hughd@google.com \
--cc=irogers@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maskray@google.com \
--cc=ndesaulniers@google.com \
--cc=rientjes@google.com \
--cc=songliubraving@fb.com \
--cc=sspatil@google.com \
--cc=surenb@google.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).