From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A97FBC433E0 for ; Wed, 12 Aug 2020 11:28:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A00A207F7 for ; Wed, 12 Aug 2020 11:28:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XjnyI23b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726453AbgHLL2l (ORCPT ); Wed, 12 Aug 2020 07:28:41 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:42076 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727773AbgHLL2i (ORCPT ); Wed, 12 Aug 2020 07:28:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597231717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KjV6K3m7aYpDUqAWmC+w9QBoR6kWl/pmzBrtpDLCLfY=; b=XjnyI23bd/wx5qQzWg1Yl3tHGH5/c9Toj6qSYmUJCSBSf0FmfjNUkCt4XGwMlpwEgr8PtQ iHvnwbQDGy47AJD0PdQiEBLF1kAgIzqJ6F1ygD0EwOWy0BL7BTVpA6+HhUGH0bVdHZY3Yl JKiIiqDhW3sbDtU+2a/cGRY04+/dnX0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-244-5J3rQyDiMHeKboA2VdWEqw-1; Wed, 12 Aug 2020 07:28:33 -0400 X-MC-Unique: 5J3rQyDiMHeKboA2VdWEqw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 56817802B54; Wed, 12 Aug 2020 11:28:31 +0000 (UTC) Received: from ws.net.home (unknown [10.40.193.69]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CA50710013D7; Wed, 12 Aug 2020 11:28:27 +0000 (UTC) Date: Wed, 12 Aug 2020 13:28:25 +0200 From: Karel Zak To: Miklos Szeredi Cc: Steven Whitehouse , David Howells , Linus Torvalds , linux-fsdevel , Al Viro , Jeff Layton , Miklos Szeredi , Nicolas Dichtel , Christian Brauner , Lennart Poettering , Linux API , Ian Kent , LSM , Linux Kernel Mailing List Subject: Re: file metadata via fs API Message-ID: <20200812112825.b52tqeuro2lquxlw@ws.net.home> References: <20200811135419.GA1263716@miu.piliscsaba.redhat.com> <52483.1597190733@warthog.procyon.org.uk> <98802.1597220949@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Aug 12, 2020 at 12:04:14PM +0200, Miklos Szeredi wrote: > On Wed, Aug 12, 2020 at 11:43 AM Steven Whitehouse wrote: > > > > Hi, > > > > On 12/08/2020 09:37, Miklos Szeredi wrote: > > [snip] > > > > > > b) The awarded performance boost is not warranted for the use cases it > > > is designed for. > > > > > This is a key point. One of the main drivers for this work is the > > efficiency improvement for large numbers of mounts. Ian and Karel have > > already provided performance measurements showing a significant benefit > > compared with what we have today. If you want to propose this > > alternative interface then you need to show that it can sustain similar > > levels of performance, otherwise it doesn't solve the problem. So > > performance numbers here would be helpful. > > Definitely. Will measure performance with the interface which Linus proposed. The proposal is based on paths and open(), how do you plan to deal with mount IDs? David's fsinfo() allows to ask for mount info by mount ID and it works well with mount notification where you get the ID. The collaboration with notification interface is critical for our use-cases. Karel -- Karel Zak http://karelzak.blogspot.com