From: Ritesh Harjani <riteshh@linux.ibm.com>
To: Yuxuan Shui <yshuiv7@gmail.com>, Christoph Hellwig <hch@infradead.org>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, tytso@mit.edu,
adilger.kernel@dilger.ca
Subject: Re: [PATCH] iomap: iomap_bmap should accept unwritten maps
Date: Tue, 25 Aug 2020 16:57:01 +0530 [thread overview]
Message-ID: <20200825112702.0D725AE045@d06av26.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <CAGqt0zxoJZrYXS+wp7bwfsajfpaotu02oUy53VkQ5CTGcE_2hA@mail.gmail.com>
On 8/25/20 4:10 PM, Yuxuan Shui wrote:
> Hi,
>
> On Tue, Aug 25, 2020 at 11:20 AM Christoph Hellwig <hch@infradead.org> wrote:
>>
>> On Tue, Aug 25, 2020 at 10:26:14AM +0100, Yuxuan Shui wrote:
>>> Hi,
>>>
>>> Do we actually want to fix this bug or not? There are a number of
>>> people actually seeing this bug.
>>
>> bmap should not succeed for unwritten extents.
>
> Why not? Unwritten extents are still allocated extents.
>
>>
>>> If you think this is not the right fix, what do you think we should
>>> do? If the correct fix is to make ext4 use iomap_swapfile_activate,
>>> maybe we should CC the ext4 people too?
>>
>> Yes, ext4 should use iomap_swapfile_activate.
>
> OK, let me CC the ext4 people.
>
> Context:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=207585
Thanks for adding ext4 list. Noticed this report for the first time now.
Maybe I missed it from fsdevel. Let me have a look at it.
-ritesh
next prev parent reply other threads:[~2020-08-25 11:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 18:36 [PATCH] iomap: iomap_bmap should accept unwritten maps Yuxuan Shui
2020-05-05 19:30 ` Darrick J. Wong
2020-08-25 9:26 ` Yuxuan Shui
2020-08-25 10:20 ` Christoph Hellwig
2020-08-25 10:40 ` Yuxuan Shui
2020-08-25 11:21 ` Christoph Hellwig
2020-08-25 11:27 ` Ritesh Harjani [this message]
2020-08-25 12:36 ` Ritesh Harjani
2020-08-25 15:49 ` Darrick J. Wong
2020-08-25 18:00 ` Ritesh Harjani
2020-08-25 15:54 ` Yuxuan Shui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825112702.0D725AE045@d06av26.portsmouth.uk.ibm.com \
--to=riteshh@linux.ibm.com \
--cc=adilger.kernel@dilger.ca \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=yshuiv7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).