linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Hao Li <lihao2018.fnst@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	ira.weiny@intel.com, linux-xfs@vger.kernel.org,
	y-goto@fujitsu.com
Subject: Re: [PATCH v2] fs: Handle I_DONTCACHE in iput_final() instead of generic_drop_inode()
Date: Mon, 7 Sep 2020 07:40:02 +1000	[thread overview]
Message-ID: <20200906214002.GI12131@dread.disaster.area> (raw)
In-Reply-To: <20200904075939.176366-1-lihao2018.fnst@cn.fujitsu.com>

On Fri, Sep 04, 2020 at 03:59:39PM +0800, Hao Li wrote:
> If generic_drop_inode() returns true, it means iput_final() can evict
> this inode regardless of whether it is dirty or not. If we check
> I_DONTCACHE in generic_drop_inode(), any inode with this bit set will be
> evicted unconditionally. This is not the desired behavior because
> I_DONTCACHE only means the inode shouldn't be cached on the LRU list.
> As for whether we need to evict this inode, this is what
> generic_drop_inode() should do. This patch corrects the usage of
> I_DONTCACHE.
> 
> This patch was proposed in [1].
> 
> [1]: https://lore.kernel.org/linux-fsdevel/20200831003407.GE12096@dread.disaster.area/
> 
> Fixes: dae2f8ed7992 ("fs: Lift XFS_IDONTCACHE to the VFS layer")
> Signed-off-by: Hao Li <lihao2018.fnst@cn.fujitsu.com>
> ---
> Changes in v2:
>  - Adjust code format
>  - Add Fixes tag in commit message
> 
>  fs/inode.c         | 4 +++-
>  include/linux/fs.h | 3 +--
>  2 files changed, 4 insertions(+), 3 deletions(-)

Looks good.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

-- 
Dave Chinner
david@fromorbit.com

  reply	other threads:[~2020-09-06 21:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-04  7:59 Hao Li
2020-09-06 21:40 ` Dave Chinner [this message]
2020-09-22  2:19   ` Hao Li
2020-09-08 23:03 ` Ira Weiny
2020-10-23  7:49   ` Li, Hao
2020-11-05 10:55     ` Li, Hao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200906214002.GI12131@dread.disaster.area \
    --to=david@fromorbit.com \
    --cc=ira.weiny@intel.com \
    --cc=lihao2018.fnst@cn.fujitsu.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=y-goto@fujitsu.com \
    --subject='Re: [PATCH v2] fs: Handle I_DONTCACHE in iput_final() instead of generic_drop_inode()' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).