From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8100AC43461 for ; Mon, 7 Sep 2020 07:13:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DDF9206D4 for ; Mon, 7 Sep 2020 07:13:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="sq7Wdxpx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726882AbgIGHNM (ORCPT ); Mon, 7 Sep 2020 03:13:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726802AbgIGHNL (ORCPT ); Mon, 7 Sep 2020 03:13:11 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B8A4C061573; Mon, 7 Sep 2020 00:13:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=t/uLsl5AXin2cAViLg4Mxi6tBTprZgEYc53F0H7n0lo=; b=sq7WdxpxnmMJ8WWESWXfPZpLsN Tff3aZz7wGmc+yxuGIUKAuDFJMRtdrK2lzhPQYUrK7JR4PMlY9vv3ZYL3q4fA+WALY9KdGFNRvJQX e7hNeZwLHyMzrHqkIOKD4ZP8rrRjFTnfq60NziD4ekdtp/gCdFPnYchURqD5g2UVibjXB9/oaDLq5 ElDFa6fffnZ1Qm3ErZispjREou77C+6jznLHmUJ1xrZV6ahhV73Ct3zuH4SlsVI86YYsx/XYNkLn8 BUDDKVnynTd1B6kQCG+HdVWyvbrhHBgXFSZ+peUShI+YET9c+XnQrnE/rtUsi8jIHziwRfBNNjvH/ cLuN7X3Q==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kFBKv-0007NJ-0x; Mon, 07 Sep 2020 07:13:09 +0000 Date: Mon, 7 Sep 2020 08:13:08 +0100 From: Christoph Hellwig To: Ritesh Harjani Cc: linux-ext4@vger.kernel.org, jack@suse.cz, tytso@mit.edu, linux-fsdevel@vger.kernel.org, darrick.wong@oracle.com, linux-kernel@vger.kernel.org, Yuxuan Shui Subject: Re: [PATCH] ext4: Implement swap_activate aops using iomap Message-ID: <20200907071308.GC27898@infradead.org> References: <20200904091653.1014334-1-riteshh@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200904091653.1014334-1-riteshh@linux.ibm.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Sep 04, 2020 at 02:46:53PM +0530, Ritesh Harjani wrote: > After moving ext4's bmap to iomap interface, swapon functionality > on files created using fallocate (which creates unwritten extents) are > failing. This is since iomap_bmap interface returns 0 for unwritten > extents and thus generic_swapfile_activate considers this as holes > and hence bail out with below kernel msg :- > > [340.915835] swapon: swapfile has holes > > To fix this we need to implement ->swap_activate aops in ext4 > which will use ext4_iomap_report_ops. Since we only need to return > the list of extents so ext4_iomap_report_ops should be enough. Looks good, Reviewed-by: Christoph Hellwig