From: Al Viro <viro@zeniv.linux.org.uk>
To: Hao Lee <haolee.swjtu@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: Eliminate a local variable to make the code more clear
Date: Tue, 8 Sep 2020 19:48:57 +0100 [thread overview]
Message-ID: <20200908184857.GT1236603@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20200908130656.GC22780@haolee.github.io>
On Tue, Sep 08, 2020 at 01:06:56PM +0000, Hao Lee wrote:
> ping
>
> On Wed, Jul 29, 2020 at 03:21:28PM +0000, Hao Lee wrote:
> > The dentry local variable is introduced in 'commit 84d17192d2afd ("get
> > rid of full-hash scan on detaching vfsmounts")' to reduce the length of
> > some long statements for example
> > mutex_lock(&path->dentry->d_inode->i_mutex). We have already used
> > inode_lock(dentry->d_inode) to do the same thing now, and its length is
> > acceptable. Furthermore, it seems not concise that assign path->dentry
> > to local variable dentry in the statement before goto. So, this function
> > would be more clear if we eliminate the local variable dentry.
How does it make the function more clear? More specifically, what
analysis of behaviour is simplified by that?
next prev parent reply other threads:[~2020-09-08 18:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 15:21 [PATCH] fs: Eliminate a local variable to make the code more clear Hao Lee
2020-08-14 6:01 ` Hao Lee
2020-09-08 13:06 ` Hao Lee
2020-09-08 18:48 ` Al Viro [this message]
2020-09-08 23:11 ` Hao Lee
2020-09-09 12:54 ` Eric W. Biederman
2020-09-09 15:32 ` Hao Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200908184857.GT1236603@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=haolee.swjtu@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).