From: Matthew Wilcox <willy@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Jan Kara <jack@suse.cz>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
xfs <linux-xfs@vger.kernel.org>,
hch@lst.de
Subject: Re: [PATCH v3] quota: widen timestamps for the fs_disk_quota structure
Date: Wed, 9 Sep 2020 02:49:33 +0100 [thread overview]
Message-ID: <20200909014933.GC6583@casper.infradead.org> (raw)
In-Reply-To: <20200909013251.GG7955@magnolia>
On Tue, Sep 08, 2020 at 06:32:51PM -0700, Darrick J. Wong wrote:
> +static inline void copy_to_xfs_dqblk_ts(const struct fs_disk_quota *d,
> + __s32 *timer_lo, __s8 *timer_hi, s64 timer)
> +{
> + *timer_lo = timer;
> + if (d->d_fieldmask & FS_DQ_BIGTIME)
> + *timer_hi = timer >> 32;
> + else
> + *timer_hi = 0;
> +}
I'm still confused by this. What breaks if you just do:
*timer_lo = timer;
*timer_hi = timer >> 32;
> memset(dst, 0, sizeof(*dst));
> + if (want_bigtime(src->d_ino_timer) || want_bigtime(src->d_spc_timer) ||
> + want_bigtime(src->d_rt_spc_timer))
> + dst->d_fieldmask |= FS_DQ_BIGTIME;
You still need this (I guess? In case somebody's written to the
d_padding2 field?)
next prev parent reply other threads:[~2020-09-09 1:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-09 1:32 [PATCH v3] quota: widen timestamps for the fs_disk_quota structure Darrick J. Wong
2020-09-09 1:49 ` Matthew Wilcox [this message]
2020-09-09 2:29 ` Darrick J. Wong
2020-09-09 10:51 ` Jan Kara
2020-09-09 12:42 ` Matthew Wilcox
2020-09-09 13:56 ` Jan Kara
2020-09-09 17:27 ` Darrick J. Wong
2020-09-10 7:07 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200909014933.GC6583@casper.infradead.org \
--to=willy@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).