From: Greg KH <greg@kroah.com>
To: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
syzbot+4191a44ad556eacc1a7a@syzkaller.appspotmail.com,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] fs: fix KMSAN uninit-value bug by initializing nd in do_file_open_root
Date: Wed, 16 Sep 2020 08:16:22 +0200 [thread overview]
Message-ID: <20200916061622.GA142621@kroah.com> (raw)
In-Reply-To: <20200916052657.18683-1-anant.thazhemadam@gmail.com>
On Wed, Sep 16, 2020 at 10:56:56AM +0530, Anant Thazhemadam wrote:
> The KMSAN bug report for the bug indicates that there exists;
> Local variable ----nd@do_file_open_root created at:
> do_file_open_root+0xa4/0xb40 fs/namei.c:3385
> do_file_open_root+0xa4/0xb40 fs/namei.c:3385
What does this "error" mean?
> Initializing nd fixes this issue, and doesn't break anything else either
>
> Fixes: https://syzkaller.appspot.com/bug?extid=4191a44ad556eacc1a7a
> Reported-by: syzbot+4191a44ad556eacc1a7a@syzkaller.appspotmail.com
> Tested-by: syzbot+4191a44ad556eacc1a7a@syzkaller.appspotmail.com
> Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
> ---
> fs/namei.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/namei.c b/fs/namei.c
> index e99e2a9da0f7..b27382586209 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -3404,7 +3404,7 @@ struct file *do_filp_open(int dfd, struct filename *pathname,
> struct file *do_file_open_root(struct dentry *dentry, struct vfsmount *mnt,
> const char *name, const struct open_flags *op)
> {
> - struct nameidata nd;
> + struct nameidata nd = {};
What exactly does setting this structure to all 0 fix here that is
currently "broken"?
confused,
greg k-h
prev parent reply other threads:[~2020-09-16 6:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 5:26 [PATCH] fs: fix KMSAN uninit-value bug by initializing nd in do_file_open_root Anant Thazhemadam
2020-09-16 5:41 ` Eric Biggers
2020-09-17 0:22 ` Al Viro
2020-09-19 14:44 ` [Linux-kernel-mentees] " Greg KH
2020-09-19 16:17 ` Al Viro
2020-09-19 16:55 ` Al Viro
2020-09-19 11:33 ` Anant Thazhemadam
2020-09-19 20:17 ` Anant Thazhemadam
2020-10-04 15:25 ` Anant Thazhemadam
2020-09-16 6:16 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200916061622.GA142621@kroah.com \
--to=greg@kroah.com \
--cc=anant.thazhemadam@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+4191a44ad556eacc1a7a@syzkaller.appspotmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).