From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDFB0C43465 for ; Sat, 19 Sep 2020 14:44:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FF1E21741 for ; Sat, 19 Sep 2020 14:44:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600526668; bh=Bxl5ZkjXMp2TPSkn3hGdRJLWXUhCroTIN94qZJ785hM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=2Bc7/1+nDruWrpN5XrmFHz7kWkuGFRh4ewAa1c7Jsfc6nR75HwqCOgFnUp3YAZcg8 obLnbYAIZL3RZNKe3GGRcNvLzA2fsPxHqGN2Prao8Y69Cnb/cHy7B3Z5MfuZA59W8n JyuIQfqlCcM3wGPWeNMe+ifVWtEsIxGXQmAbKGO0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726549AbgISOoY (ORCPT ); Sat, 19 Sep 2020 10:44:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:44998 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726312AbgISOoY (ORCPT ); Sat, 19 Sep 2020 10:44:24 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5B8912098B; Sat, 19 Sep 2020 14:44:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600526663; bh=Bxl5ZkjXMp2TPSkn3hGdRJLWXUhCroTIN94qZJ785hM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HvAmBzz4j84+nW2I/6iTGG7u+tu/+fVFlTymgUy9x48ZHF94OcJYcK3VRxYLyYTyb gLdVK3Jz7CFYgGvvk2LFTH6hxIvgXGihiig+gwgxNnILZPGg1qc84/ZJiaXzrUMjzZ 9BfhiCQpyntL37/8AEdpoY9xJH4Lfe+mv81k+IoQ= Date: Sat, 19 Sep 2020 16:44:51 +0200 From: Greg KH To: Al Viro Cc: Eric Biggers , linux-fsdevel@vger.kernel.org, Anant Thazhemadam , linux-kernel-mentees@lists.linuxfoundation.org, syzbot+4191a44ad556eacc1a7a@syzkaller.appspotmail.com, linux-kernel@vger.kernel.org Subject: Re: [Linux-kernel-mentees] [PATCH] fs: fix KMSAN uninit-value bug by initializing nd in do_file_open_root Message-ID: <20200919144451.GF2712238@kroah.com> References: <20200916052657.18683-1-anant.thazhemadam@gmail.com> <20200916054157.GC825@sol.localdomain> <20200917002238.GO3421308@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200917002238.GO3421308@ZenIV.linux.org.uk> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Sep 17, 2020 at 01:22:38AM +0100, Al Viro wrote: > On Tue, Sep 15, 2020 at 10:41:57PM -0700, Eric Biggers wrote: > > > Looking at the actual KMSAN report, it looks like it's nameidata::dir_mode or > > nameidata::dir_uid that is uninitialized. You need to figure out the correct > > solution, not just blindly initialize with zeroes -- that could hide a bug. > > Is there a bug that is preventing these fields from being initialized to the > > correct values, are these fields being used when they shouldn't be, etc... > > False positive, and this is the wrong place to shut it up. > > ->dir_uid and ->dir_mode are set when link_path_walk() resolves the pathname > to directory + final component. They are used when deciding whether to reject > a trailing symlink (on fs.protected_symlinks setups) and whether to allow > creation in sticky directories (on fs.protected_regular and fs.protected_fifos > setups). Both operations really need the results of successful link_path_walk(). > > I don't see how that could be not a false positive. If we hit the use in > may_create_in_sticky(), we'd need the combination of > * pathname that consists only of slashes (or it will be initialized) > * LAST_NORM in nd->last_type, which is flat-out impossible, since > we are left with LAST_ROOT for such pathnames. The same goes for > may_follow_link() use - we need WALK_TRAILING in flags to hit it in the > first place, which can come from two sources - > return walk_component(nd, WALK_TRAILING); > in lookup_last() (and walk_component() won't go anywhere near the > call chain leading to may_follow_link() without LAST_NORM in nd->last_type) > and > res = step_into(nd, WALK_TRAILING, dentry, inode, seq); > in open_last_lookups(), which also won't go anywhere near that line without > LAST_NORM in the nd->last_type. > > IOW, unless we manage to call that without having called link_path_walk() > at all or after link_path_walk() returning an error, we shouldn't hit > that. And if we *do* go there without link_path_walk() or with an error > from link_path_walk(), we have a much worse problem. > > I want to see the details of reproducer. If it's for real, we have a much > more serious problem; if it's a false positive, the right place to deal > with it would be elsewhere (perhaps on return from link_path_walk() with > a slashes-only pathname), but in any case it should only be done after we > manage to understand what's going on. Reproducer is pretty simple: https://syzkaller.appspot.com/text?tag=ReproC&x=13974b2f100000 Now if that is actually valid or not, I don't know... thanks, greg k-h