From: "Pali Rohár" <pali@kernel.org>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
linux-kernel@vger.kernel.org, dsterba@suse.cz, aaptel@suse.com,
willy@infradead.org, rdunlap@infradead.org, joe@perches.com,
mark@harmstone.com, nborisov@suse.com
Subject: Re: [PATCH v5 08/10] fs/ntfs3: Add Kconfig, Makefile and doc
Date: Mon, 21 Sep 2020 15:26:31 +0200 [thread overview]
Message-ID: <20200921132631.q6jfmbhqf6j6ay5t@pali> (raw)
In-Reply-To: <20200911141018.2457639-9-almaz.alexandrovich@paragon-software.com>
On Friday 11 September 2020 17:10:16 Konstantin Komarov wrote:
> +Mount Options
> +=============
> +
> +The list below describes mount options supported by NTFS3 driver in addition to
> +generic ones.
> +
> +===============================================================================
> +
> +nls=name This option informs the driver how to interpret path
> + strings and translate them to Unicode and back. If
> + this option is not set, the default codepage will be
> + used (CONFIG_NLS_DEFAULT).
> + Examples:
> + 'nls=utf8'
> +
> +nls_alt=name This option extends "nls". It will be used to translate
> + path string to Unicode if primary nls failed.
> + Examples:
> + 'nls_alt=cp1251'
Hello! I'm looking at other filesystem drivers and no other with UNICODE
semantic (vfat, udf, isofs) has something like nls_alt option.
So do we really need it? And if yes, it should be added to all other
UNICODE filesystem drivers for consistency.
But I'm very sceptical if such thing is really needed. nls= option just
said how to convert UNICODE code points for userpace. This option is
passed by userspace (when mounting disk), so userspace already know what
it wanted. And it should really use this encoding for filenames (e.g.
utf8 or cp1251) which already told to kernel.
next prev parent reply other threads:[~2020-09-21 13:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 14:10 [PATCH v5 00/10] NTFS read-write driver GPL implementation by Paragon Software Konstantin Komarov
2020-09-11 14:10 ` [PATCH v5 01/10] fs/ntfs3: Add headers and misc files Konstantin Komarov
2020-09-12 2:28 ` Joe Perches
2020-09-11 14:10 ` [PATCH v5 03/10] fs/ntfs3: Add bitmap Konstantin Komarov
2020-09-13 18:43 ` Joe Perches
2020-09-14 2:38 ` Matthew Wilcox
2020-09-18 16:35 ` Konstantin Komarov
2020-09-18 16:54 ` Matthew Wilcox
2020-09-25 16:04 ` Konstantin Komarov
2020-09-18 16:29 ` Konstantin Komarov
2020-09-18 16:38 ` Matthew Wilcox
2020-09-11 14:10 ` [PATCH v5 05/10] fs/ntfs3: Add attrib operations Konstantin Komarov
2020-09-11 14:10 ` [PATCH v5 06/10] fs/ntfs3: Add compression Konstantin Komarov
2020-09-11 14:10 ` [PATCH v5 08/10] fs/ntfs3: Add Kconfig, Makefile and doc Konstantin Komarov
2020-09-21 13:26 ` Pali Rohár [this message]
2020-09-25 16:30 ` Konstantin Komarov
2020-09-26 8:23 ` Pali Rohár
2020-10-09 15:31 ` Konstantin Komarov
2020-10-09 15:47 ` Pali Rohár
2020-09-11 14:10 ` [PATCH v5 09/10] fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile Konstantin Komarov
2020-09-11 14:10 ` [PATCH v5 10/10] fs/ntfs3: Add MAINTAINERS Konstantin Komarov
[not found] ` <20200911141018.2457639-3-almaz.alexandrovich@paragon-software.com>
[not found] ` <c819ee72-6bb0-416d-dfc4-0bc2ad6d0ccd@harmstone.com>
2020-09-18 16:39 ` [PATCH v5 02/10] fs/ntfs3: Add initialization of super block Konstantin Komarov
[not found] ` <2011cd8c-7dc4-b2e7-114b-d5647336ec92@harmstone.com>
2020-09-18 16:43 ` Konstantin Komarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200921132631.q6jfmbhqf6j6ay5t@pali \
--to=pali@kernel.org \
--cc=aaptel@suse.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=dsterba@suse.cz \
--cc=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark@harmstone.com \
--cc=nborisov@suse.com \
--cc=rdunlap@infradead.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).