From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AC4FC4727C for ; Tue, 29 Sep 2020 14:37:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D32E2074F for ; Tue, 29 Sep 2020 14:37:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=android.com header.i=@android.com header.b="YdyLS5Ee" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730833AbgI2Oh0 (ORCPT ); Tue, 29 Sep 2020 10:37:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730131AbgI2Oh0 (ORCPT ); Tue, 29 Sep 2020 10:37:26 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF1BDC061755 for ; Tue, 29 Sep 2020 07:37:25 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id k10so5687775wru.6 for ; Tue, 29 Sep 2020 07:37:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4thglTsU672R6183seyBnljqOq4ywCJEfxOVEmyHhBc=; b=YdyLS5EenXDRxghn69b9SpbqPtIfctAotTCVJYuhsSJwzn3N555MgFY53pQxvCS7cj KQQxQ1IbPkCt+yiN2OZbuHK/9RsG5qndjhi8InnjMRI6SuJ3dD37R9XXPUut1F9gU9+S KPaCAJXubIHsmVFCfo+br3kfyP4dDEcp5NvDbM9LydE0n5UOohb2cyYrdY3irscF8Bzk slySsHDAnBPEo7oh+7revV68LyXhlZBpg6dr5TdANFp9syC7WZWHlncy12r25pdu91Xx IuZyHSP86XnZ8b7CoxfPcEWUcrD3Peu3hxSYf3GzGhqu4lFfJjY2UnHMOOwn0MxzdlwX 5d6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4thglTsU672R6183seyBnljqOq4ywCJEfxOVEmyHhBc=; b=rEfekQVsoWbSP3aNA/blExCTZr/doFLftSxfj4NssK9nMblhRZ5s8H+hPakWkzE422 jjriXRX7epFVuz/AsPCHOCxXkZkYsrGXnD6APevZrfVgvhJv6Lcb6LxDzB/0IloCEW0p e3LnD9o/y8IiORXpvGLaOqonLbbTL8gfbkHa1oyh7LENAdzr0JBz1e5TFLJsioEaX9oX aMpaeHH4/gfIIyzDS+LrtsJr92b2r2m+X4Md8a5g17l3qFw+UxaVZ2J0ahy03dR2Jtk/ /nUYSHluSZH7GpZspwLdeZvbulRx5ww7VeXH/ptr5DK7FG8fqk59Cj9LJ7NeeYSqdVb8 Ds4A== X-Gm-Message-State: AOAM533bU8R8vasmwGsWFAgiGja468grIhuDZw3AgzSTPNDBVCvXKEfK rCWMnasaP6TY7HJTJHe2mI/X3g== X-Google-Smtp-Source: ABdhPJwTnLt9PJBcyxeHBl/hpr0rDd9CLDdBUt1LQth6Z+obyqx4rWDWAJnjil4yI+hg9W2jV1TMPA== X-Received: by 2002:adf:c404:: with SMTP id v4mr4640623wrf.17.1601390244674; Tue, 29 Sep 2020 07:37:24 -0700 (PDT) Received: from google.com ([2a00:79e0:d:210:7220:84ff:fe09:7d5c]) by smtp.gmail.com with ESMTPSA id 11sm5418223wmi.14.2020.09.29.07.37.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Sep 2020 07:37:24 -0700 (PDT) Date: Tue, 29 Sep 2020 15:37:22 +0100 From: Alessio Balsini To: Miklos Szeredi Cc: Akilesh Kailash , Amir Goldstein , Antonio SJ Musumeci , David Anderson , Giuseppe Scrivano , Jann Horn , Jens Axboe , Martijn Coenen , Palmer Dabbelt , Paul Lawrence , Stefano Duo , Zimuzo Ezeozue , fuse-devel@lists.sourceforge.net, kernel-team@android.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V9 1/4] fuse: Definitions and ioctl() for passthrough Message-ID: <20200929143722.GB1680101@google.com> References: <20200924131318.2654747-1-balsini@android.com> <20200924131318.2654747-2-balsini@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200924131318.2654747-2-balsini@android.com> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hi, I noticed the following fixup suggested by Amir slipped from this submission. Thanks, Alessio ---8<--- diff --git a/fs/fuse/passthrough.c b/fs/fuse/passthrough.c index b7d1a5517ffd..eba26196be92 100644 --- a/fs/fuse/passthrough.c +++ b/fs/fuse/passthrough.c @@ -185,7 +185,7 @@ int fuse_passthrough_setup(struct fuse_req *req, unsigned int fd) passthrough_inode = file_inode(passthrough_filp); passthrough_sb = passthrough_inode->i_sb; fs_stack_depth = passthrough_sb->s_stack_depth + 1; - ret = -EEXIST; + ret = -EINVAL; if (fs_stack_depth > FILESYSTEM_MAX_STACK_DEPTH) { pr_err("FUSE: maximum fs stacking depth exceeded for passthrough\n"); goto out;