From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BE40C433DF for ; Wed, 14 Oct 2020 05:35:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E70B2222A for ; Wed, 14 Oct 2020 05:35:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602653707; bh=d4wYMD9zxWGP4ViJqAYsTUccVHhOPjIdZNDpBMkcIPA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=BRfFYngHyib2XSTWQg4ixhlofobEPSkamj0Kwq9RpJzuNRt+Eq5m9kf21/4JHX9ew U+YEqv2s5TKctx4mXVz86V814ne+xoa7+yw+vmJgBLBoq8SOyj/kbJpLrN2OUVV38M V7ZOGk9hKgh6Z5bS5zjBYnC/vn2NQN8WuETThLrs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730283AbgJNFev (ORCPT ); Wed, 14 Oct 2020 01:34:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:40304 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727849AbgJNFev (ORCPT ); Wed, 14 Oct 2020 01:34:51 -0400 Received: from kernel.org (unknown [87.71.73.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A671F2177B; Wed, 14 Oct 2020 05:34:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602653690; bh=d4wYMD9zxWGP4ViJqAYsTUccVHhOPjIdZNDpBMkcIPA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JzTNGhOiNyXtNTueXhjUVMEfQTx5q+4aBDwojw4g95GwoRgomkCxd+hVvWVnaqAjE L8pOvlVoMurMUNwWQqJvFWzplk02ZoX2HEAQlaZc6iqUx8dj9+KMw47anVntrWxplH 0gT3KWk7AWi2bc4K2wN8bQTJha+ec7Hqxd8ZD09Y= Date: Wed, 14 Oct 2020 08:34:29 +0300 From: Mike Rapoport To: Randy Dunlap Cc: Muchun Song , Eric Dumazet , Eric Dumazet , Cong Wang , Greg KH , rafael@kernel.org, "Michael S. Tsirkin" , Jason Wang , David Miller , Jakub Kicinski , Alexey Dobriyan , Andrew Morton , Alexey Kuznetsov , Hideaki YOSHIFUJI , Steffen Klassert , Herbert Xu , Shakeel Butt , Will Deacon , Michal Hocko , Roman Gushchin , Neil Brown , Sami Tolvanen , "Kirill A. Shutemov" , Feng Tang , Paolo Abeni , Willem de Bruijn , Florian Westphal , gustavoars@kernel.org, Pablo Neira Ayuso , Dexuan Cui , Jakub Sitnicki , Peter Zijlstra , Christian Brauner , "Eric W. Biederman" , Thomas Gleixner , dave@stgolabs.net, Michel Lespinasse , Jann Horn , chenqiwu@xiaomi.com, christophe.leroy@c-s.fr, Minchan Kim , Martin KaFai Lau , Alexei Starovoitov , Daniel Borkmann , Miaohe Lin , Kees Cook , LKML , virtualization@lists.linux-foundation.org, Linux Kernel Network Developers , linux-fsdevel , linux-mm , Michael Kerrisk Subject: Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo Message-ID: <20201014053429.GI4251@kernel.org> References: <9262ea44-fc3a-0b30-54dd-526e16df85d1@gmail.com> <20201013080906.GD4251@kernel.org> <20201013151215.GG4251@kernel.org> <3aa9ff1a-e04f-517c-5ebb-2c27804c143a@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3aa9ff1a-e04f-517c-5ebb-2c27804c143a@infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Oct 13, 2020 at 08:21:13AM -0700, Randy Dunlap wrote: > On 10/13/20 8:12 AM, Mike Rapoport wrote: > > On Tue, Oct 13, 2020 at 07:43:59AM -0700, Randy Dunlap wrote: > >> On 10/13/20 1:09 AM, Mike Rapoport wrote: > >>> On Mon, Oct 12, 2020 at 05:53:01PM +0800, Muchun Song wrote: > >>>> On Mon, Oct 12, 2020 at 5:24 PM Eric Dumazet wrote: > >>>>> > >>>>> On 10/12/20 10:39 AM, Muchun Song wrote: > >>>>>> On Mon, Oct 12, 2020 at 3:42 PM Eric Dumazet wrote: > >>>> > >>>> We are not complaining about TCP using too much memory, but how do > >>>> we know that TCP uses a lot of memory. When I firstly face this problem, > >>>> I do not know who uses the 25GB memory and it is not shown in the /proc/meminfo. > >>>> If we can know the amount memory of the socket buffer via /proc/meminfo, we > >>>> may not need to spend a lot of time troubleshooting this problem. Not everyone > >>>> knows that a lot of memory may be used here. But I believe many people > >>>> should know /proc/meminfo to confirm memory users. > >>> > >>> If I undestand correctly, the problem you are trying to solve is to > >>> simplify troubleshooting of memory usage for people who may not be aware > >>> that networking stack can be a large memory consumer. > >>> > >>> For that a paragraph in 'man 5 proc' maybe a good start: > >>> > >>> >From ddbcf38576d1a2b0e36fe25a27350d566759b664 Mon Sep 17 00:00:00 2001 > >>> From: Mike Rapoport > >>> Date: Tue, 13 Oct 2020 11:07:35 +0300 > >>> Subject: [PATCH] proc.5: meminfo: add not anout network stack memory > >>> consumption > >>> > >>> Signed-off-by: Mike Rapoport > >>> --- > >>> man5/proc.5 | 8 ++++++++ > >>> 1 file changed, 8 insertions(+) > >>> > >>> diff --git a/man5/proc.5 b/man5/proc.5 > >>> index ed309380b..8414676f1 100644 > >>> --- a/man5/proc.5 > >>> +++ b/man5/proc.5 > >>> @@ -3478,6 +3478,14 @@ Except as noted below, > >>> all of the fields have been present since at least Linux 2.6.0. > >>> Some fields are displayed only if the kernel was configured > >>> with various options; those dependencies are noted in the list. > >>> +.IP > >>> +Note that significant part of memory allocated by the network stack > >>> +is not accounted in the file. > >>> +The memory consumption of the network stack can be queried > >>> +using > >>> +.IR /proc/net/sockstat > >>> +or > >>> +.BR ss (8) > >>> .RS > >>> .TP > >>> .IR MemTotal " %lu" > >> > >> Hi Mike, > >> > >> Could you tell us what units those values are in? > >> or is that already explained somewhere else? > > > > It is described a few lines above and anyway, "MemTotal" is a part of > > the diff context ;-) > > with no units AFAICT. > > But I was unclear. I wasn't referring to /proc/meminfo, but instead > to /proc/net/sockstat and its units: > > sockets: used 1224 > TCP: inuse 11 orphan 1 tw 1 alloc 26 mem 3 > UDP: inuse 4 mem 2 > UDPLITE: inuse 0 > RAW: inuse 0 > FRAG: inuse 0 memory 0 > > E.g., for TCP and UDP, are those socket counts or some unit of memory? > If units of memory, what unit size? Ah, these are in 4k pages, AFAIU. And, as it seems /proc/net/sockstat lacks a description in proc.5 at all... > thanks. > -- > ~Randy > > -- Sincerely yours, Mike.