From: Matthew Wilcox <willy@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 07/14] iomap: Support THPs in readpage
Date: Wed, 14 Oct 2020 18:35:00 +0100 [thread overview]
Message-ID: <20201014173500.GR20115@casper.infradead.org> (raw)
In-Reply-To: <20201014163936.GJ9832@magnolia>
On Wed, Oct 14, 2020 at 09:39:36AM -0700, Darrick J. Wong wrote:
> On Wed, Oct 14, 2020 at 04:03:50AM +0100, Matthew Wilcox (Oracle) wrote:
> > +/*
> > + * The page that was passed in has become Uptodate. This may be due to
> > + * the storage being synchronous or due to a page split finding the page
> > + * is actually uptodate. The page is still locked.
> > + * Lift this into the VFS at some point.
> > + */
> > +#define AOP_UPDATED_PAGE (AOP_TRUNCATED_PAGE + 1)
>
> Er... why not lift it now?
>
> "Because touching fs.h causes the whole kernel to be rebuilt and that's
> annoying"? :D
Hah! Because I already have a patch series out that does lift it to
the VFS:
https://lore.kernel.org/linux-fsdevel/20201009143104.22673-1-willy@infradead.org/
which I'm kind of hoping gets merged first. Then I can adjust this patch.
> > +static int iomap_split_page(struct inode *inode, struct page *page)
> > +{
> > + struct page *head = thp_head(page);
> > + bool uptodate = iomap_range_uptodate(inode, head,
> > + (page - head) * PAGE_SIZE, PAGE_SIZE);
> > +
> > + iomap_page_release(head);
> > + if (split_huge_page(page) < 0) {
> > + unlock_page(page);
> > + return AOP_TRUNCATED_PAGE;
> > + }
> > + if (!uptodate)
> > + return 0;
> > + SetPageUptodate(page);
> > + return AOP_UPDATED_PAGE;
> > +}
> > +
> > int
> > iomap_readpage(struct page *page, const struct iomap_ops *ops)
> > {
> > struct iomap_readpage_ctx ctx = { .cur_page = page };
> > - struct inode *inode = page->mapping->host;
> > + struct inode *inode = thp_head(page)->mapping->host;
> > unsigned poff;
> > loff_t ret;
> >
> > - trace_iomap_readpage(page->mapping->host, 1);
> > + trace_iomap_readpage(inode, 1);
> > +
> > + if (PageTransCompound(page)) {
> > + int status = iomap_split_page(inode, page);
> > + if (status == AOP_UPDATED_PAGE) {
> > + unlock_page(page);
>
> /me wonders why not do the unlock in iomap_split_page?
This is working around AOP_UPDATED_PAGE not existing in the VFS. So
adjusting this patch becomes:
int status = iomap_split_page(inode, page);
if (status)
return status;
next prev parent reply other threads:[~2020-10-14 17:35 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 3:03 [PATCH 00/14] Transparent Huge Page support for XFS Matthew Wilcox (Oracle)
2020-10-14 3:03 ` [PATCH 01/14] fs: Support THPs in vfs_dedupe_file_range Matthew Wilcox (Oracle)
2020-10-14 16:12 ` Darrick J. Wong
2020-10-14 17:16 ` Matthew Wilcox
2020-10-14 3:03 ` [PATCH 02/14] fs: Make page_mkwrite_check_truncate thp-aware Matthew Wilcox (Oracle)
2020-10-14 16:17 ` Darrick J. Wong
2020-10-14 17:23 ` Matthew Wilcox
2020-10-14 3:03 ` [PATCH 03/14] iomap: Support THPs in BIO completion path Matthew Wilcox (Oracle)
2020-10-15 9:50 ` Christoph Hellwig
2020-10-14 3:03 ` [PATCH 04/14] iomap: Support THPs in iomap_adjust_read_range Matthew Wilcox (Oracle)
2020-10-15 9:50 ` Christoph Hellwig
2020-10-14 3:03 ` [PATCH 05/14] iomap: Support THPs in invalidatepage Matthew Wilcox (Oracle)
2020-10-14 16:33 ` Darrick J. Wong
2020-10-14 17:26 ` Matthew Wilcox
2020-10-14 20:00 ` Brian Foster
2020-10-14 3:03 ` [PATCH 06/14] iomap: Support THPs in iomap_is_partially_uptodate Matthew Wilcox (Oracle)
2020-10-14 3:03 ` [PATCH 07/14] iomap: Support THPs in readpage Matthew Wilcox (Oracle)
2020-10-14 16:39 ` Darrick J. Wong
2020-10-14 17:35 ` Matthew Wilcox [this message]
2020-10-14 3:03 ` [PATCH 08/14] iomap: Support THPs in readahead Matthew Wilcox (Oracle)
2020-10-15 9:52 ` Christoph Hellwig
2020-10-14 3:03 ` [PATCH 09/14] iomap: Change iomap_write_begin calling convention Matthew Wilcox (Oracle)
2020-10-14 16:47 ` Darrick J. Wong
2020-10-14 17:41 ` Matthew Wilcox
2020-10-14 18:08 ` Matthew Wilcox
2020-10-14 3:03 ` [PATCH 10/14] iomap: Handle THPs when writing to pages Matthew Wilcox (Oracle)
2020-10-14 3:03 ` [PATCH 11/14] iomap: Support THP writeback Matthew Wilcox (Oracle)
2020-10-14 3:03 ` [PATCH 12/14] iomap: Inline data shouldn't see THPs Matthew Wilcox (Oracle)
2020-10-14 3:03 ` [PATCH 13/14] iomap: Handle tail pages in iomap_page_mkwrite Matthew Wilcox (Oracle)
2020-10-14 3:03 ` [PATCH 14/14] xfs: Support THPs Matthew Wilcox (Oracle)
2020-10-14 16:51 ` Darrick J. Wong
2020-10-14 17:30 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014173500.GR20115@casper.infradead.org \
--to=willy@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).