From: "Matthew Wilcox (Oracle)" <willy@infradead.org> To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fscrypt@vger.kernel.org Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org> Subject: [PATCH 5/6] fs: Turn decrypt_bh into decrypt_bio Date: Thu, 22 Oct 2020 22:22:27 +0100 Message-ID: <20201022212228.15703-6-willy@infradead.org> (raw) In-Reply-To: <20201022212228.15703-1-willy@infradead.org> Pass a bio to decrypt_bio instead of a buffer_head to decrypt_bh. Another step towards doing decryption per-BIO instead of per-BH. Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- fs/buffer.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index 627ae1d853c0..f859e0929b7e 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -299,22 +299,24 @@ static void end_buffer_async_read(struct buffer_head *bh, int uptodate) return; } -struct decrypt_bh_ctx { +struct decrypt_bio_ctx { struct work_struct work; - struct buffer_head *bh; + struct bio *bio; }; -static void decrypt_bh(struct work_struct *work) +static void decrypt_bio(struct work_struct *work) { - struct decrypt_bh_ctx *ctx = - container_of(work, struct decrypt_bh_ctx, work); - struct buffer_head *bh = ctx->bh; + struct decrypt_bio_ctx *ctx = + container_of(work, struct decrypt_bio_ctx, work); + struct bio *bio = ctx->bio; + struct buffer_head *bh = bio->bi_private; int err; err = fscrypt_decrypt_pagecache_blocks(bh->b_page, bh->b_size, bh_offset(bh)); end_buffer_async_read(bh, err == 0); kfree(ctx); + bio_put(bio); } /* @@ -3093,13 +3095,12 @@ static void end_bio_bh_io_sync(struct bio *bio) /* Decrypt if needed */ if ((bio_data_dir(bio) == READ) && uptodate && fscrypt_inode_uses_fs_layer_crypto(bh->b_page->mapping->host)) { - struct decrypt_bh_ctx *ctx = kmalloc(sizeof(*ctx), GFP_ATOMIC); + struct decrypt_bio_ctx *ctx = kmalloc(sizeof(*ctx), GFP_ATOMIC); if (ctx) { - INIT_WORK(&ctx->work, decrypt_bh); - ctx->bh = bh; + INIT_WORK(&ctx->work, decrypt_bio); + ctx->bio = bio; fscrypt_enqueue_decrypt_work(&ctx->work); - bio_put(bio); return; } uptodate = 0; -- 2.28.0
next prev parent reply index Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-10-22 21:22 [PATCH 0/6] Make block_read_full_page synchronous Matthew Wilcox (Oracle) 2020-10-22 21:22 ` [PATCH 1/6] block: Add blk_completion Matthew Wilcox (Oracle) 2020-10-27 18:30 ` Christoph Hellwig 2020-10-22 21:22 ` [PATCH 2/6] fs: Return error from block_read_full_page Matthew Wilcox (Oracle) 2020-10-22 21:22 ` [PATCH 3/6] fs: Convert block_read_full_page to be synchronous Matthew Wilcox (Oracle) 2020-10-22 23:35 ` Eric Biggers 2020-10-22 23:40 ` Eric Biggers 2020-10-23 13:21 ` Matthew Wilcox 2020-10-23 16:13 ` Eric Biggers 2020-10-23 20:42 ` Matthew Wilcox 2020-10-22 21:22 ` [PATCH 4/6] fs: Hoist fscrypt decryption to bio completion handler Matthew Wilcox (Oracle) 2020-10-22 21:22 ` Matthew Wilcox (Oracle) [this message] 2020-10-22 21:22 ` [PATCH 6/6] fs: Convert block_read_full_page to be synchronous with fscrypt enabled Matthew Wilcox (Oracle)
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201022212228.15703-6-willy@infradead.org \ --to=willy@infradead.org \ --cc=linux-block@vger.kernel.org \ --cc=linux-fscrypt@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-Fsdevel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \ linux-fsdevel@vger.kernel.org public-inbox-index linux-fsdevel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git