From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A7D0C56202 for ; Tue, 27 Oct 2020 09:49:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD85621D24 for ; Tue, 27 Oct 2020 09:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603792142; bh=wcj6sqvr10YA2nIxp8QFswfSebjeDskPYpJl+9Hjv5I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=jXQc7SE9UOIL8igpgwDPlzVQepbdmaBzKg3yx+9A0cyTq+tctY80kN88KL0cqaZzX X8pgKOrsvLrMDbx9+wU+rzy+yq8O/RU88Dt/moXVslU24tjIS0yxArg/Z/0HwwvySY IALrjTYVgZDfFvNSYBggZWkvZS/tjtvxR1OpgVXg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2895960AbgJ0JtB (ORCPT ); Tue, 27 Oct 2020 05:49:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:40918 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2895946AbgJ0JtB (ORCPT ); Tue, 27 Oct 2020 05:49:01 -0400 Received: from kernel.org (unknown [87.70.96.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C7CAF20759; Tue, 27 Oct 2020 09:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603792140; bh=wcj6sqvr10YA2nIxp8QFswfSebjeDskPYpJl+9Hjv5I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=li/s39XFgB24jJSUCjqf8zNKcx6M9bh+uU6phnSX6LJCJRBegjZ0SOdTEugjflO1e WgquGhsCXXsZ3V2YD7JRAQc2nfgUEjBNCSoKoM6GZx5SGcpgMkSqE8zAapjDeCrodZ Fc2zbcZd41+mXwuTSqYXiceoEMKXjGqiG53f7j/s= Date: Tue, 27 Oct 2020 11:48:45 +0200 From: Mike Rapoport To: David Hildenbrand Cc: "Edgecombe, Rick P" , "akpm@linux-foundation.org" , "tycho@tycho.ws" , "cl@linux.com" , "hpa@zytor.com" , "peterz@infradead.org" , "catalin.marinas@arm.com" , "linux-kselftest@vger.kernel.org" , "dave.hansen@linux.intel.com" , "will@kernel.org" , "linux-mm@kvack.org" , "kirill@shutemov.name" , "viro@zeniv.linux.org.uk" , "rppt@linux.ibm.com" , "linux-arch@vger.kernel.org" , "Williams, Dan J" , "bp@alien8.de" , "willy@infradead.org" , "luto@kernel.org" , "arnd@arndb.de" , "shuah@kernel.org" , "tglx@linutronix.de" , "linux-nvdimm@lists.01.org" , "linux-riscv@lists.infradead.org" , "x86@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-fsdevel@vger.kernel.org" , "Reshetova, Elena" , "palmer@dabbelt.com" , "mingo@redhat.com" , "mtk.manpages@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-api@vger.kernel.org" , "jejb@linux.ibm.com" , "paul.walmsley@sifive.com" , "mark.rutland@arm.com" Subject: Re: [PATCH v7 3/7] set_memory: allow set_direct_map_*_noflush() for multiple pages Message-ID: <20201027094845.GJ1154158@kernel.org> References: <20201026083752.13267-1-rppt@kernel.org> <20201026083752.13267-4-rppt@kernel.org> <9202c4c1-9f1f-175f-0a85-fc8c30bc5e3b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9202c4c1-9f1f-175f-0a85-fc8c30bc5e3b@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Oct 27, 2020 at 09:12:23AM +0100, David Hildenbrand wrote: > On 26.10.20 20:01, Edgecombe, Rick P wrote: > > On Mon, 2020-10-26 at 10:37 +0200, Mike Rapoport wrote: > >> +++ b/arch/x86/mm/pat/set_memory.c > >> @@ -2184,14 +2184,14 @@ static int __set_pages_np(struct page *page, > >> int numpages) > >> return __change_page_attr_set_clr(&cpa, 0); > >> } > >> > >> -int set_direct_map_invalid_noflush(struct page *page) > >> +int set_direct_map_invalid_noflush(struct page *page, int numpages) > >> { > >> - return __set_pages_np(page, 1); > >> + return __set_pages_np(page, numpages); > >> } > >> > >> -int set_direct_map_default_noflush(struct page *page) > >> +int set_direct_map_default_noflush(struct page *page, int numpages) > >> { > >> - return __set_pages_p(page, 1); > >> + return __set_pages_p(page, numpages); > >> } > > > > Somewhat related to your other series, this could result in large NP > > pages and trip up hibernate. > > > > It feels somewhat desirable to disable hibernation once secretmem is > enabled, right? Otherwise you'll be writing out your secrets to swap, > where they will remain even after booting up again ... > > Skipping secretmem pages when hibernating is the wrong approach I guess ... Completely agree. I'll look into preventing hibernation from touching secretmem. > -- > Thanks, > > David / dhildenb > -- Sincerely yours, Mike.