From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RFC] Removing b_end_io
Date: Tue, 27 Oct 2020 19:25:46 +0100 [thread overview]
Message-ID: <20201027182546.GA3269@lst.de> (raw)
In-Reply-To: <20201025044438.GI20115@casper.infradead.org>
On Sun, Oct 25, 2020 at 04:44:38AM +0000, Matthew Wilcox wrote:
>
> On my laptop, I have about 31MB allocated to buffer_heads.
>
> buffer_head 182728 299910 104 39 1 : tunables 0 0 0 : slabdata 7690 7690 0
>
> Reducing the size of the buffer_head by 8 bytes gets us to 96 bytes,
> which means we get 42 per page instead of 39 and saves me 2MB of memory.
>
> I think b_end_io() is ripe for removal. It's only used while the I/O
> is in progress, and it's always set to end_bio_bh_io_sync() which
> may set the quiet bit, calls ->b_end_io and calls bio_put().
>
> So how about this as an approach? Only another 40 or so call-sites
> to take care of to eliminate b_end_io from the buffer_head. Yes, this
> particular example should be entirely rewritten to do away with buffer
> heads, but that's been true since 2006. I'm looking for an approach
> which can be implemented quickly since the buffer_head does not appear
> to be going away any time soon.
I think this looks pretty reasonable.
prev parent reply other threads:[~2020-10-27 18:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-25 4:44 [RFC] Removing b_end_io Matthew Wilcox
2020-10-25 15:56 ` Theodore Y. Ts'o
2020-10-25 18:58 ` Matthew Wilcox
2020-10-27 18:25 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027182546.GA3269@lst.de \
--to=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).