From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D10E8C4363A for ; Thu, 29 Oct 2020 00:56:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81EE220724 for ; Thu, 29 Oct 2020 00:56:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603932985; bh=3DtSsbNWZaTf7v/7udK+AIDJ92sxyETNXeC2IzpbaLk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=y7oZJmYvYJjaN8Xo13mkDYK1cCfACUHd6fzmD1moswGc4Pmbl7vwdEeMWBZmrurN0 tLwfAFzw93RfHEjkXgA2yPqWtTEKbiN+SqNrhDOdqte5wkm3lag6nm8rd0jwUn6jNv CdbLYoYr5cEkUInJ8Mjz4L6Pc/pJl5N35SFY2ooM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403764AbgJ2A4X (ORCPT ); Wed, 28 Oct 2020 20:56:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:60524 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731618AbgJ1WRg (ORCPT ); Wed, 28 Oct 2020 18:17:36 -0400 Received: from kernel.org (unknown [87.70.96.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7666B246B2; Wed, 28 Oct 2020 11:16:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603883801; bh=3DtSsbNWZaTf7v/7udK+AIDJ92sxyETNXeC2IzpbaLk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nNqIykwPXzPeiPb6AYNYHQQXiJyXiYtwLr73B//voWR8TZa6Eb5++4CieyFXxEh1h 1/1jSd7uHggtcYYQ6K5jPMWeaE8D3Si3dAD3bEDewru+HlpqXxaIyeUj0n/GkzF1sK d2ZhRYNYGHxIcFCusFeRPJXtjEnybkIYxxUOxr+4= Date: Wed, 28 Oct 2020 13:16:31 +0200 From: Mike Rapoport To: Geert Uytterhoeven Cc: Andrew Morton , Alexey Dobriyan , Catalin Marinas , Greg Ungerer , John Paul Adrian Glaubitz , Jonathan Corbet , Matt Turner , Meelis Roos , Michael Schmitz , Mike Rapoport , Russell King , Tony Luck , Vineet Gupta , Will Deacon , alpha , Linux ARM , "open list:DOCUMENTATION" , Linux FS Devel , "linux-ia64@vger.kernel.org" , Linux Kernel Mailing List , linux-m68k , Linux MM , arcml Subject: Re: [PATCH 11/13] m68k/mm: make node data and node setup depend on CONFIG_DISCONTIGMEM Message-ID: <20201028111631.GF1428094@kernel.org> References: <20201027112955.14157-1-rppt@kernel.org> <20201027112955.14157-12-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hi Geert, On Wed, Oct 28, 2020 at 10:25:49AM +0100, Geert Uytterhoeven wrote: > Hi Mike, > > On Tue, Oct 27, 2020 at 12:31 PM Mike Rapoport wrote: > > From: Mike Rapoport > > > > The pg_data_t node structures and their initialization currently depends on > > !CONFIG_SINGLE_MEMORY_CHUNK. Since they are required only for DISCONTIGMEM > > make this dependency explicit and replace usage of > > CONFIG_SINGLE_MEMORY_CHUNK with CONFIG_DISCONTIGMEM where appropriate. > > > > The CONFIG_SINGLE_MEMORY_CHUNK was implicitly disabled on the ColdFire MMU > > variant, although it always presumed a single memory bank. As there is no > > actual need for DISCONTIGMEM in this case, make sure that ColdFire MMU > > systems set CONFIG_SINGLE_MEMORY_CHUNK to 'y'. > > > > Signed-off-by: Mike Rapoport > > Thanks for your patch! > > > --- > > arch/m68k/Kconfig.cpu | 6 +++--- > > arch/m68k/include/asm/page_mm.h | 2 +- > > arch/m68k/mm/init.c | 4 ++-- > > 3 files changed, 6 insertions(+), 6 deletions(-) > > Is there any specific reason you didn't convert the checks for > CONFIG_SINGLE_MEMORY_CHUNK in arch/m68k/kernel/setup_mm.c In arch/m68k/kernel/setup_mm.c the CONFIG_SINGLE_MEMORY_CHUNK is needed for the case when a system has two banks, the kernel is loaded into the second bank and so the first bank cannot be used as normal memory. It does not matter what memory model will be used in this case. > and arch/m68k/include/asm/virtconvert.h? I remember I had build errors and troubles with include file dependencies if I changed it there, but I might be mistaken. I'll recheck again. > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds -- Sincerely yours, Mike.