From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CF84C55178 for ; Fri, 6 Nov 2020 17:46:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0815922241 for ; Fri, 6 Nov 2020 17:46:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604684814; bh=4o77fqFuBZvPiDYAW30olp6av5R3X4/iv+z7vMt50bA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fXVZgaDkyKdUpuAdkJPyrTN8GBZjYsHQqUlw7HPoktRquKkIO6aLQtm0NO1YknJZq 9a8uNH24H9NnTTy/QYfVn7gOINPUmsk4SDdtSaDZ9qK+9FXBC1oP5TV5T8r6BGvCEM KuiGBwmElxM34CwWMHrXaKeDiRblU5fDIFmxziGQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727608AbgKFRqv (ORCPT ); Fri, 6 Nov 2020 12:46:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:54086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726010AbgKFRqu (ORCPT ); Fri, 6 Nov 2020 12:46:50 -0500 Received: from sol.localdomain (172-10-235-113.lightspeed.sntcca.sbcglobal.net [172.10.235.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 96A4B2151B; Fri, 6 Nov 2020 17:46:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604684810; bh=4o77fqFuBZvPiDYAW30olp6av5R3X4/iv+z7vMt50bA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CQIkI1axVORa3PbPPE/4evBmU3xr79YrxNJvILQKc/9EgpD9wzoUDOapCBTSofz8d QTqdPdkByflxlpoDy7egZoLU3F+pdjtbXKtt1GrCGC8o6QSm1KNHnghF5FZ0wdAksW zEtsWWIH2jOZoshKVrojhTsdCy2J+fHU63gXVUz0= Date: Fri, 6 Nov 2020 09:46:47 -0800 From: Eric Biggers To: Lokesh Gidra Cc: Andrea Arcangeli , Alexander Viro , James Morris , Stephen Smalley , Casey Schaufler , "Serge E. Hallyn" , Paul Moore , Eric Paris , Daniel Colascione , Kees Cook , "Eric W. Biederman" , KP Singh , David Howells , Thomas Cedeno , Anders Roxell , Sami Tolvanen , Matthew Garrett , Aaron Goidel , Randy Dunlap , "Joel Fernandes (Google)" , YueHaibing , Christian Brauner , Alexei Starovoitov , Alexey Budankov , Adrian Reber , Aleksa Sarai , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, kaleshsingh@google.com, calin@google.com, surenb@google.com, nnk@google.com, jeffv@google.com, kernel-team@android.com, linux-mm@kvack.org, Andrew Morton , hch@infradead.org, Daniel Colascione Subject: Re: [PATCH v12 2/4] fs: add LSM-supporting anon-inode interface Message-ID: <20201106174647.GC845@sol.localdomain> References: <20201106155626.3395468-1-lokeshgidra@google.com> <20201106155626.3395468-3-lokeshgidra@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201106155626.3395468-3-lokeshgidra@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Nov 06, 2020 at 07:56:24AM -0800, Lokesh Gidra wrote: > +/** > + * Like anon_inode_getfd(), but creates a new !S_PRIVATE anon inode rather than > + * reuse the singleton anon inode, and call the anon_init_security_anon() LSM > + * hook. This allows the inode to have its own security context and for a LSM "call the anon_init_security_anon() LSM hook" => "calls the inode_init_security_anon() LSM hook". Otherwise this patch looks okay. Feel free to add: Reviewed-by: Eric Biggers - Eric