From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40C72C2D0E4 for ; Thu, 12 Nov 2020 19:11:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3A022222F for ; Thu, 12 Nov 2020 19:11:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Lfgr6Sop" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726736AbgKLTLP (ORCPT ); Thu, 12 Nov 2020 14:11:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:57522 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726545AbgKLTLO (ORCPT ); Thu, 12 Nov 2020 14:11:14 -0500 Received: from kernel.org (unknown [77.125.7.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4ED2420B80; Thu, 12 Nov 2020 19:11:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605208274; bh=MIxnxk8miGxsOAzLOjR0YQwvefMMlSnyIpNObX3bazE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lfgr6SopUO1UFj23PxPDrczZI2Z07mjlkTk9QvecjRTBlADpd716o8if/9yyxRk7g xI2oQQDnwoNGiO63mmwDaugb47yuMbunU88tXUJ5BrXohQVKnTRS/4u2b+FX78WjQq MhLrmrH3jLOtufoFfcYH7BLcpF2br3ZAL0IVCgfQ= Date: Thu, 12 Nov 2020 21:11:05 +0200 From: Mike Rapoport To: Matthew Wilcox Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , Hugh Dickins , Johannes Weiner , Yang Shi , Dave Chinner , linux-kernel@vger.kernel.org, Jan Kara , William Kucharski Subject: Re: [PATCH v3 01/12] mm: Make pagecache tagged lookups return only head pages Message-ID: <20201112191105.GR4758@kernel.org> References: <20201026041408.25230-1-willy@infradead.org> <20201026041408.25230-2-willy@infradead.org> <20201028075056.GB1362354@kernel.org> <20201112174150.GC17076@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112174150.GC17076@casper.infradead.org> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Nov 12, 2020 at 05:41:50PM +0000, Matthew Wilcox wrote: > On Wed, Oct 28, 2020 at 09:50:56AM +0200, Mike Rapoport wrote: > > > @@ -2074,8 +2074,8 @@ EXPORT_SYMBOL(find_get_pages_contig); > > > * @nr_pages: the maximum number of pages > > > * @pages: where the resulting pages are placed > > > * > > > - * Like find_get_pages, except we only return pages which are tagged with > > > - * @tag. We update @index to index the next page for the traversal. > > > + * Like find_get_pages(), except we only return head pages which are tagged > > > + * with @tag. We update @index to index the next page for the traversal. > > > > Nit: ^ next head page > > I don't love the sentence anyway. How about: > > * Like find_get_pages(), except we only return head pages which are tagged > * with @tag. @index is updated to the index immediately after the last > * page we return, ready for the next iteration. I like it. -- Sincerely yours, Mike.