Linux-Fsdevel Archive on lore.kernel.org
 help / color / Atom feed
From: Chengguang Xu <cgxu519@mykernel.net>
To: miklos@szeredi.hu, jack@suse.cz, amir73il@gmail.com
Cc: linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Chengguang Xu <cgxu519@mykernel.net>
Subject: [RFC PATCH v4 9/9] ovl: implement containerized syncfs for overlayfs
Date: Fri, 13 Nov 2020 14:55:55 +0800
Message-ID: <20201113065555.147276-10-cgxu519@mykernel.net> (raw)
In-Reply-To: <20201113065555.147276-1-cgxu519@mykernel.net>

Now overlayfs can only sync dirty inode during syncfs,
so remove unnecessary sync_filesystem() on upper file
system.

Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
 fs/overlayfs/super.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index 982b3954b47c..58507f1cd583 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -15,6 +15,8 @@
 #include <linux/seq_file.h>
 #include <linux/posix_acl_xattr.h>
 #include <linux/exportfs.h>
+#include <linux/blkdev.h>
+#include <linux/writeback.h>
 #include "overlayfs.h"
 
 MODULE_AUTHOR("Miklos Szeredi <miklos@szeredi.hu>");
@@ -270,8 +272,7 @@ static int ovl_sync_fs(struct super_block *sb, int wait)
 	 * Not called for sync(2) call or an emergency sync (SB_I_SKIP_SYNC).
 	 * All the super blocks will be iterated, including upper_sb.
 	 *
-	 * If this is a syncfs(2) call, then we do need to call
-	 * sync_filesystem() on upper_sb, but enough if we do it when being
+	 * if this is a syncfs(2) call, it will be enough we do it when being
 	 * called with wait == 1.
 	 */
 	if (!wait)
@@ -280,7 +281,11 @@ static int ovl_sync_fs(struct super_block *sb, int wait)
 	upper_sb = ovl_upper_mnt(ofs)->mnt_sb;
 
 	down_read(&upper_sb->s_umount);
-	ret = sync_filesystem(upper_sb);
+	wait_sb_inodes(upper_sb);
+	if (upper_sb->s_op->sync_fs)
+		ret = upper_sb->s_op->sync_fs(upper_sb, wait);
+	if (!ret)
+		ret = sync_blockdev(upper_sb->s_bdev);
 	up_read(&upper_sb->s_umount);
 
 	return ret;
-- 
2.26.2



  parent reply index

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-13  6:55 [RFC PATCH v4 0/9] " Chengguang Xu
2020-11-13  6:55 ` [RFC PATCH v4 1/9] ovl: setup overlayfs' private bdi Chengguang Xu
2020-11-13  6:55 ` [RFC PATCH v4 2/9] ovl: implement ->writepages operation Chengguang Xu
2020-11-13  6:55 ` [RFC PATCH v4 3/9] ovl: implement overlayfs' ->evict_inode operation Chengguang Xu
2020-11-13  6:55 ` [RFC PATCH v4 4/9] ovl: mark overlayfs' inode dirty on modification Chengguang Xu
2021-04-09 13:45   ` Miklos Szeredi
2021-04-12 11:58     ` Chengguang Xu
2020-11-13  6:55 ` [RFC PATCH v4 5/9] ovl: mark overlayfs' inode dirty on shared mmap Chengguang Xu
2020-11-13  6:55 ` [RFC PATCH v4 6/9] ovl: implement overlayfs' ->write_inode operation Chengguang Xu
2021-04-09 13:49   ` Miklos Szeredi
2021-04-14  6:14     ` Chengguang Xu
2020-11-13  6:55 ` [RFC PATCH v4 7/9] ovl: cache dirty overlayfs' inode Chengguang Xu
2021-04-09 13:50   ` Miklos Szeredi
2021-04-13  2:14     ` Chengguang Xu
2021-04-13  8:43       ` Miklos Szeredi
2021-04-14  5:53         ` Chengguang Xu
2020-11-13  6:55 ` [RFC PATCH v4 8/9] fs: export wait_sb_inodes() Chengguang Xu
2020-11-13  6:55 ` Chengguang Xu [this message]
2021-04-09 13:51   ` [RFC PATCH v4 9/9] ovl: implement containerized syncfs for overlayfs Miklos Szeredi
2021-04-12 12:24     ` Chengguang Xu
2021-04-12 14:22       ` Miklos Szeredi
2020-12-04 14:49 ` 回复:[RFC PATCH v4 0/9] " Chengguang Xu
2020-12-04 15:02   ` [RFC " Miklos Szeredi
2020-12-04 16:40   ` 回复:[RFC " Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201113065555.147276-10-cgxu519@mykernel.net \
    --to=cgxu519@mykernel.net \
    --cc=amir73il@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Fsdevel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \
		linux-fsdevel@vger.kernel.org
	public-inbox-index linux-fsdevel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git