From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38829C388F7 for ; Fri, 13 Nov 2020 17:21:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D268A20A8B for ; Fri, 13 Nov 2020 17:21:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726431AbgKMRVB (ORCPT ); Fri, 13 Nov 2020 12:21:01 -0500 Received: from mx2.suse.de ([195.135.220.15]:58540 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726166AbgKMRU7 (ORCPT ); Fri, 13 Nov 2020 12:20:59 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 72459ABD9; Fri, 13 Nov 2020 17:21:11 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 643F2DA87A; Fri, 13 Nov 2020 18:19:28 +0100 (CET) Date: Fri, 13 Nov 2020 18:19:28 +0100 From: David Sterba To: Boqun Feng Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Filipe Manana , Peter Zijlstra , Jan Kara , David Sterba , Nikolay Borisov , "Darrick J. Wong" , Alexander Viro , Ingo Molnar Subject: Re: [RFC] fs: Avoid to use lockdep information if it's turned off Message-ID: <20201113171927.GG6756@suse.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Boqun Feng , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Filipe Manana , Peter Zijlstra , Jan Kara , David Sterba , Nikolay Borisov , "Darrick J. Wong" , Alexander Viro , Ingo Molnar References: <20201110013739.686731-1-boqun.feng@gmail.com> <20201110153327.GL6756@suse.cz> <20201111140121.GN6756@suse.cz> <20201112032212.GF3025@boqun-archlinux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112032212.GF3025@boqun-archlinux> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Nov 12, 2020 at 11:22:12AM +0800, Boqun Feng wrote: > For the "BUG: MAX_LOCKDEP_CHAIN_HLOCKS too low!" warning, do you see > that every time when you run xfstests and don't see other lockdep > splats? If so, that means we reach the limitation of number of lockdep > hlock chains, and we should fix that. It's not every time and depends on the release, eg. I found no reports in a sample log for 5.7..5.9, while there are many for 5.2..5.6 and 5.10, every 2nd or 3rd run. [ 0.185150] ... MAX_LOCKDEP_SUBCLASSES: 8 [ 0.186202] ... MAX_LOCK_DEPTH: 48 [ 0.187286] ... MAX_LOCKDEP_KEYS: 8192 [ 0.188404] ... CLASSHASH_SIZE: 4096 [ 0.189519] ... MAX_LOCKDEP_ENTRIES: 32768 [ 0.190672] ... MAX_LOCKDEP_CHAINS: 65536 [ 0.191814] ... CHAINHASH_SIZE: 32768