From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F048C56202 for ; Tue, 17 Nov 2020 17:04:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7EF2246A6 for ; Tue, 17 Nov 2020 17:04:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="DBjGqfkc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727512AbgKQREP (ORCPT ); Tue, 17 Nov 2020 12:04:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:48554 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726204AbgKQREO (ORCPT ); Tue, 17 Nov 2020 12:04:14 -0500 Received: from google.com (unknown [104.132.1.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9438122447; Tue, 17 Nov 2020 17:04:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605632654; bh=RI02fUAgmCDGR1I9KhbEZKJySeezxBuuog/z0BglPjE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DBjGqfkcNFh7VnYo3RQNdBge1TQ+YYC4YKNDLYI8nPndHth5oUkMgNCidgSm2Hu0u KLA2crWMx3LsXcgN+T8C26/Kt+F8ujLobWFjlbLjJfxmDID5V1znx5uEEnL0pL3olq 21GDqIO5jmYr1HGyy4Cx80uxW0RI1rifflYbZMYQ= Date: Tue, 17 Nov 2020 09:04:11 -0800 From: Jaegeuk Kim To: "Theodore Y. Ts'o" Cc: Daniel Rosenberg , Eric Biggers , Andreas Dilger , Chao Yu , Alexander Viro , Richard Weinberger , linux-fscrypt@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mtd@lists.infradead.org, Gabriel Krisman Bertazi , kernel-team@android.com Subject: Re: [PATCH v2 2/3] fscrypt: Have filesystems handle their d_ops Message-ID: <20201117170411.GC1636127@google.com> References: <20201117040315.28548-1-drosen@google.com> <20201117040315.28548-3-drosen@google.com> <20201117140326.GA445084@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201117140326.GA445084@mit.edu> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 11/17, Theodore Y. Ts'o wrote: > On Tue, Nov 17, 2020 at 04:03:14AM +0000, Daniel Rosenberg wrote: > > This shifts the responsibility of setting up dentry operations from > > fscrypt to the individual filesystems, allowing them to have their own > > operations while still setting fscrypt's d_revalidate as appropriate. > > > > Most filesystems can just use generic_set_encrypted_ci_d_ops, unless > > they have their own specific dentry operations as well. That operation > > will set the minimal d_ops required under the circumstances. > > > > Since the fscrypt d_ops are set later on, we must set all d_ops there, > > since we cannot adjust those later on. This should not result in any > > change in behavior. > > > > Signed-off-by: Daniel Rosenberg > > Acked-by: Theodore Ts'o Hi Ted/Richard, I'd like to pick this patch series in f2fs/dev for -next, so please let me know if you have any concern. Thanks,