linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <christian.brauner@ubuntu.com>
To: Giuseppe Scrivano <gscrivan@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux@rasmusvillemoes.dk,
	viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
	containers@lists.linux-foundation.org
Subject: Re: [PATCH v3 0/2] fs, close_range: add flag CLOSE_RANGE_CLOEXEC
Date: Fri, 4 Dec 2020 12:32:38 +0100	[thread overview]
Message-ID: <20201204113238.bazik6j3p7v5g2ak@wittgenstein> (raw)
In-Reply-To: <20201118104746.873084-1-gscrivan@redhat.com>

On Wed, Nov 18, 2020 at 11:47:44AM +0100, Giuseppe Scrivano wrote:
> When the new flag is used, close_range will set the close-on-exec bit
> for the file descriptors instead of close()-ing them.
> 
> It is useful for e.g. container runtimes that want to minimize the
> number of syscalls used after a seccomp profile is installed but want
> to keep some fds open until the container process is executed.
> 
> v3:
> - fixed indentation
> - selftests: use ASSERT_EQ instead of EXPECT_EQ for hard failures
> 
> v2: https://lkml.kernel.org/lkml/20201019102654.16642-1-gscrivan@redhat.com/
> - move close_range(..., CLOSE_RANGE_CLOEXEC) implementation to a separate function.
> - use bitmap_set() to set the close-on-exec bits in the bitmap.
> - add test with rlimit(RLIMIT_NOFILE) in place.
> - use "cur_max" that is already used by close_range(..., 0).
> 
> v1: https://lkml.kernel.org/lkml/20201013140609.2269319-1-gscrivan@redhat.com/
> 
> Giuseppe Scrivano (2):
>   fs, close_range: add flag CLOSE_RANGE_CLOEXEC
>   selftests: core: add tests for CLOSE_RANGE_CLOEXEC
> 
>  fs/file.c                                     | 44 ++++++++---
>  include/uapi/linux/close_range.h              |  3 +
>  .../testing/selftests/core/close_range_test.c | 74 +++++++++++++++++++
>  3 files changed, 111 insertions(+), 10 deletions(-)

I've picked this up and stuffed it into -next. This solves a real
problem and I don't want it to sit around another merge window. (If you
pick it up later I'll simply drop it, Al.)

Christian

      parent reply	other threads:[~2020-12-04 11:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-18 10:47 [PATCH v3 0/2] fs, close_range: add flag CLOSE_RANGE_CLOEXEC Giuseppe Scrivano
2020-11-18 10:47 ` [PATCH v3 1/2] " Giuseppe Scrivano
2020-11-18 10:47 ` [PATCH v3 2/2] selftests: core: add tests for CLOSE_RANGE_CLOEXEC Giuseppe Scrivano
2020-11-22 13:42   ` [selftests] 4d9c16a494: kernel-selftests.core.make_fail kernel test robot
2020-12-04 11:32 ` Christian Brauner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201204113238.bazik6j3p7v5g2ak@wittgenstein \
    --to=christian.brauner@ubuntu.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=gscrivan@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).