Re: [PATCH v15 09/10] fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5845 bytes --]

Hi Konstantin,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.10 next-20201215]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Konstantin-Komarov/NTFS-read-write-driver-GPL-implementation-by-Paragon-Software/20201212-002454
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 33dc9614dc208291d0c4bcdeb5d30d481dcd2c4c
config: parisc-randconfig-r003-20201217 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1b2891569e06a47bd2cfaf86fe29919d40e3b486
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Konstantin-Komarov/NTFS-read-write-driver-GPL-implementation-by-Paragon-Software/20201212-002454
        git checkout 1b2891569e06a47bd2cfaf86fe29919d40e3b486
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=parisc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from fs/ntfs3/xattr.c:17:
   fs/ntfs3/ntfs.h:427:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
     427 | static const inline __le16 *attr_name(const struct ATTRIB *attr)
         | ^~~~~~
   fs/ntfs3/ntfs.h:544:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
     544 | static const inline __le16 *le_name(const struct ATTR_LIST_ENTRY *le)
         | ^~~~~~
   fs/ntfs3/xattr.c: In function 'ntfs_get_acl_ex':
>> fs/ntfs3/xattr.c:512:4: error: implicit declaration of function 'set_cached_acl'; did you mean 'is_uncached_acl'? [-Werror=implicit-function-declaration]
     512 |    set_cached_acl(inode, type, acl);
         |    ^~~~~~~~~~~~~~
         |    is_uncached_acl
   fs/ntfs3/xattr.c: In function 'ntfs_init_acl':
>> fs/ntfs3/xattr.c:1013:7: error: 'struct inode' has no member named 'i_default_acl'
    1013 |  inode->i_default_acl = NULL;
         |       ^~
>> fs/ntfs3/xattr.c:1046:8: error: 'struct inode' has no member named 'i_acl'
    1046 |   inode->i_acl = NULL;
         |        ^~
   cc1: some warnings being treated as errors


vim +512 fs/ntfs3/xattr.c

65c2a48e1da93c6 Konstantin Komarov 2020-12-11  480  
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  481  static struct posix_acl *ntfs_get_acl_ex(struct inode *inode, int type,
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  482  					 int locked)
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  483  {
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  484  	struct ntfs_inode *ni = ntfs_i(inode);
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  485  	const char *name;
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  486  	struct posix_acl *acl;
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  487  	size_t req;
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  488  	int err;
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  489  	void *buf;
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  490  
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  491  	/* allocate PATH_MAX bytes */
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  492  	buf = __getname();
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  493  	if (!buf)
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  494  		return ERR_PTR(-ENOMEM);
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  495  
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  496  	/* Possible values of 'type' was already checked above */
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  497  	name = type == ACL_TYPE_ACCESS ? XATTR_NAME_POSIX_ACL_ACCESS :
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  498  					 XATTR_NAME_POSIX_ACL_DEFAULT;
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  499  
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  500  	if (!locked)
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  501  		ni_lock(ni);
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  502  
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  503  	err = ntfs_getxattr_hlp(inode, name, buf, PATH_MAX, &req);
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  504  
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  505  	if (!locked)
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  506  		ni_unlock(ni);
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  507  
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  508  	/* Translate extended attribute to acl */
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  509  	if (err > 0) {
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  510  		acl = posix_acl_from_xattr(&init_user_ns, buf, err);
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  511  		if (!IS_ERR(acl))
65c2a48e1da93c6 Konstantin Komarov 2020-12-11 @512  			set_cached_acl(inode, type, acl);
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  513  	} else {
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  514  		acl = err == -ENODATA ? NULL : ERR_PTR(err);
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  515  	}
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  516  
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  517  	__putname(buf);
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  518  
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  519  	return acl;
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  520  }
65c2a48e1da93c6 Konstantin Komarov 2020-12-11  521  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28827 bytes --]