From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B7F9C433DB for ; Mon, 4 Jan 2021 16:13:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D84B8221F1 for ; Mon, 4 Jan 2021 16:13:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729803AbhADQNY (ORCPT ); Mon, 4 Jan 2021 11:13:24 -0500 Received: from mga12.intel.com ([192.55.52.136]:58368 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729914AbhADQNR (ORCPT ); Mon, 4 Jan 2021 11:13:17 -0500 IronPort-SDR: 0DWrWzUEWLCNIS74p5n/erbSmXiSwqKzMc/9mRBvOJR/iq5c/wlmqwn2Eys+XrJkR0e6lPlpKq JBQII0R+MDjQ== X-IronPort-AV: E=McAfee;i="6000,8403,9854"; a="156167540" X-IronPort-AV: E=Sophos;i="5.78,474,1599548400"; d="scan'208";a="156167540" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2021 08:12:36 -0800 IronPort-SDR: G4qPXJ/u5P7tzi0LQVR3bnnVjEt8/+JF5VfHTuJGXPNUaBkbM3EQCfJ8JGG7X1LE/P/0DsZhkr CrUb9zAWHYxg== X-IronPort-AV: E=Sophos;i="5.78,474,1599548400"; d="scan'208";a="378471325" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2021 08:12:36 -0800 Date: Mon, 4 Jan 2021 08:12:36 -0800 From: Ira Weiny To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, kernel test robot , Vineet Gupta , linux-snps-arc@lists.infradead.org, Vineet Gupta , Andrew Morton , Matthew Wilcox , Jan Kara , linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org Subject: Re: [PATCH v2] fs/dax: include to fix build error on ARC Message-ID: <20210104161236.GE3097896@iweiny-DESK2.sc.intel.com> References: <20210101042914.5313-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210101042914.5313-1-rdunlap@infradead.org> User-Agent: Mutt/1.11.1 (2018-12-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Dec 31, 2020 at 08:29:14PM -0800, Randy Dunlap wrote: > fs/dax.c uses copy_user_page() but ARC does not provide that interface, > resulting in a build error. > > Provide copy_user_page() in (beside copy_page()) and > add to fs/dax.c to fix the build error. > > ../fs/dax.c: In function 'copy_cow_page_dax': > ../fs/dax.c:702:2: error: implicit declaration of function 'copy_user_page'; did you mean 'copy_to_user_page'? [-Werror=implicit-function-declaration] > > Fixes: cccbce671582 ("filesystem-dax: convert to dax_direct_access()") > Reported-by: kernel test robot > Signed-off-by: Randy Dunlap Looks reasonable Reviewed-by: Ira Weiny > Cc: Vineet Gupta > Cc: linux-snps-arc@lists.infradead.org > Cc: Dan Williams > Acked-by: Vineet Gupta > Cc: Andrew Morton > Cc: Matthew Wilcox > Cc: Jan Kara > Cc: linux-fsdevel@vger.kernel.org > Cc: linux-nvdimm@lists.01.org > --- > v2: rebase, add more Cc: > > arch/arc/include/asm/page.h | 1 + > fs/dax.c | 1 + > 2 files changed, 2 insertions(+) > > --- lnx-511-rc1.orig/fs/dax.c > +++ lnx-511-rc1/fs/dax.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include > #include > > #define CREATE_TRACE_POINTS > --- lnx-511-rc1.orig/arch/arc/include/asm/page.h > +++ lnx-511-rc1/arch/arc/include/asm/page.h > @@ -10,6 +10,7 @@ > #ifndef __ASSEMBLY__ > > #define clear_page(paddr) memset((paddr), 0, PAGE_SIZE) > +#define copy_user_page(to, from, vaddr, pg) copy_page(to, from) > #define copy_page(to, from) memcpy((to), (from), PAGE_SIZE) > > struct vm_area_struct; > _______________________________________________ > Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org > To unsubscribe send an email to linux-nvdimm-leave@lists.01.org