From: Kari Argillander <kari.argillander@gmail.com>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"pali@kernel.org" <pali@kernel.org>,
"dsterba@suse.cz" <dsterba@suse.cz>,
"aaptel@suse.com" <aaptel@suse.com>,
"willy@infradead.org" <willy@infradead.org>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"joe@perches.com" <joe@perches.com>,
"mark@harmstone.com" <mark@harmstone.com>,
"nborisov@suse.com" <nborisov@suse.com>,
"linux-ntfs-dev@lists.sourceforge.net"
<linux-ntfs-dev@lists.sourceforge.net>,
"anton@tuxera.com" <anton@tuxera.com>,
"dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
"hch@lst.de" <hch@lst.de>,
"ebiggers@kernel.org" <ebiggers@kernel.org>,
"andy.lavr@gmail.com" <andy.lavr@gmail.com>
Subject: Re: [PATCH v17 02/10] fs/ntfs3: Add initialization of super block
Date: Mon, 18 Jan 2021 16:09:31 +0200 [thread overview]
Message-ID: <20210118140931.e2qdposfez2jsbbr@kari-VirtualBox> (raw)
In-Reply-To: <750a0cef33f34c0989cacfb0bcd4ac5e@paragon-software.com>
On Mon, Jan 18, 2021 at 09:35:05AM +0000, Konstantin Komarov wrote:
> From: Kari Argillander <kari.argillander@gmail.com>
> Sent: Sunday, January 3, 2021 10:50 PM
> > On Thu, Dec 31, 2020 at 06:23:53PM +0300, Konstantin Komarov wrote:
> > > diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
> >
> > > +int ntfs_create_inode(struct inode *dir, struct dentry *dentry,
> > > + const struct cpu_str *uni, umode_t mode, dev_t dev,
> > > + const char *symname, u32 size, int excl,
> > > + struct ntfs_fnd *fnd, struct inode **new_inode)
> > > +{
> >
> > > +#ifdef CONFIG_NTFS3_FS_POSIX_ACL
> >
> > In Kconfig this is NTFS3_POSIX_ACL. This repeat every file.
> >
>
> This is OK. You may refer to similar parts of ext4/btrfs sources as a
> reference:
> fs/ext4/Kconfig or fs/btrfs/Kconfig
>
But in ext4 and btrfs Kconfig specify *_FS_POSIX_ACL. In ntfs3 Kconfig
specify *_POSIX_ACL. So we missing _FS_ in our Kconfig?
next prev parent reply other threads:[~2021-01-18 14:10 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 15:23 [PATCH v17 00/10] NTFS read-write driver GPL implementation by Paragon Software Konstantin Komarov
2020-12-31 15:23 ` [PATCH v17 01/10] fs/ntfs3: Add headers and misc files Konstantin Komarov
2021-01-03 23:17 ` Kari Argillander
2021-01-19 10:43 ` Dan Carpenter
2021-01-19 20:34 ` Kari Argillander
2020-12-31 15:23 ` [PATCH v17 02/10] fs/ntfs3: Add initialization of super block Konstantin Komarov
2021-01-03 19:50 ` Kari Argillander
2021-01-18 9:35 ` Konstantin Komarov
2021-01-18 14:09 ` Kari Argillander [this message]
2021-01-19 4:03 ` Kari Argillander
2021-01-20 7:20 ` Kari Argillander
2020-12-31 15:23 ` [PATCH v17 03/10] fs/ntfs3: Add bitmap Konstantin Komarov
2020-12-31 15:23 ` [PATCH v17 04/10] fs/ntfs3: Add file operations and implementation Konstantin Komarov
2021-01-03 21:57 ` Kari Argillander
2021-01-03 22:04 ` Matthew Wilcox
2021-01-18 10:00 ` Konstantin Komarov
2021-01-18 14:24 ` Kari Argillander
2021-01-04 2:18 ` Matthew Wilcox
2020-12-31 15:23 ` [PATCH v17 05/10] fs/ntfs3: Add attrib operations Konstantin Komarov
2021-01-04 0:25 ` Kari Argillander
2021-01-18 12:01 ` Konstantin Komarov
2020-12-31 15:23 ` [PATCH v17 06/10] fs/ntfs3: Add compression Konstantin Komarov
2020-12-31 15:23 ` [PATCH v17 07/10] fs/ntfs3: Add NTFS journal Konstantin Komarov
2021-01-03 22:47 ` Kari Argillander
2020-12-31 15:23 ` [PATCH v17 08/10] fs/ntfs3: Add Kconfig, Makefile and doc Konstantin Komarov
2021-01-03 22:07 ` Kari Argillander
2021-01-18 11:43 ` Konstantin Komarov
2021-01-18 13:42 ` Mark Harmstone
2020-12-31 15:24 ` [PATCH v17 09/10] fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile Konstantin Komarov
2020-12-31 15:24 ` [PATCH v17 10/10] fs/ntfs3: Add MAINTAINERS Konstantin Komarov
2021-01-03 20:01 ` Kari Argillander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118140931.e2qdposfez2jsbbr@kari-VirtualBox \
--to=kari.argillander@gmail.com \
--cc=aaptel@suse.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=andy.lavr@gmail.com \
--cc=anton@tuxera.com \
--cc=dan.carpenter@oracle.com \
--cc=dsterba@suse.cz \
--cc=ebiggers@kernel.org \
--cc=hch@lst.de \
--cc=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=mark@harmstone.com \
--cc=nborisov@suse.com \
--cc=pali@kernel.org \
--cc=rdunlap@infradead.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).