From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A6C9C433E9 for ; Mon, 18 Jan 2021 21:44:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7262322E02 for ; Mon, 18 Jan 2021 21:44:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394538AbhARVnm (ORCPT ); Mon, 18 Jan 2021 16:43:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388645AbhARVnA (ORCPT ); Mon, 18 Jan 2021 16:43:00 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 241C7C061573; Mon, 18 Jan 2021 13:42:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jyoij0RsS5818dRxwbFzHUwXraId823WtMIOT0DRHDU=; b=VzVcYihCG2lQP/J+Q1f+x03Lb9 t98+gi+/CgDqKJW57GasOmXfZ3X/Ontf1Jy+h/Vufi5B7DBL/HO/K7pli0GoxlhgV4CWuP8HVAA+p UEsGaHbKjGVwlYGofoUPnuvNO73ROV5shc4ls71ZVzf2Dh11tGvjQ+id/8rPf6jHuBSAKONc3bR6i Rzn2GPfmu17eKyqf8RZUDJBIXZv6b54wvSN8Mhm05NsnaCjlAF5rUJ7Z+lpbUgR5IQ18hs+ZoxhDn zbAHC8NJ+gHgwD7F5WV/s27g3iR6VIXzaHQaQtXv2xZT50RWD4R4/xzGZzwMaf6TpjBHnMTqwhVci YdKB8mjQ==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l1cHJ-00DRHV-4I; Mon, 18 Jan 2021 21:41:39 +0000 Date: Mon, 18 Jan 2021 21:41:37 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, avi@scylladb.com Subject: Re: [PATCH 10/11] iomap: add a IOMAP_DIO_UNALIGNED flag Message-ID: <20210118214137.GG2260413@casper.infradead.org> References: <20210118193516.2915706-1-hch@lst.de> <20210118193516.2915706-11-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210118193516.2915706-11-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jan 18, 2021 at 08:35:15PM +0100, Christoph Hellwig wrote: > Add a flag to signal an I/O that is not file system block aligned. > + if (dio_flags & IOMAP_DIO_UNALIGNED) { There are a number of things that DIO has to be aligned to -- memory addresses, for example. Can we be a little more verbose about what is unaligned here? eg if (dio_flags & IOMAP_DIO_FS_UNALIGNED) (or FSBLK_UNALIGNED, or ... something).