linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	avi@scylladb.com, Dave Chinner <david@fromorbit.com>
Subject: Re: reduce sub-block DIO serialisation v4
Date: Sat, 23 Jan 2021 10:57:06 -0800	[thread overview]
Message-ID: <20210123185706.GG1282159@magnolia> (raw)
In-Reply-To: <20210122162043.616755-1-hch@lst.de>

On Fri, Jan 22, 2021 at 05:20:32PM +0100, Christoph Hellwig wrote:
> This takes the approach from Dave, but adds a new flag instead of abusing
> the nowait one, and keeps a simpler calling convention for iomap_dio_rw.

Hm.  I realized while putting together for-next branches that I really
would have preferred the three iomap patches at the start so that I
could push those parts through the iomap tree.  The changes required to
resequence the series is minor and the iomap changes (AFAICT) are inert
if the calling fs doesn't set IOMAP_DIO_OVERWRITE_ONLY, so I think it's
low risk to push the iomap changes into iomap-for-next as a 5.12 thing.

The rest of the xfs patches in this series would form the basis of a
second week pull request (or not) since I think I ought to evaluate the
effects on performance for a little longer.

That said, if you /don't/ want me to pull any of this for 5.12, holler
and I'll pull back. :)

--D

> Changes since v3:
>  - further comment improvements
>  - micro-optimize an alignment check
> 
> Changes since v2:
>  - add another sanity check in __iomap_dio_rw
>  - rename IOMAP_DIO_UNALIGNED to IOMAP_DIO_OVERWRITE_ONLY
>  - use more consistent parameter naming
>  - improve a few comments
>  - cleanup an if statement
> 
> Changes since v1:
>  - rename the new flags
>  - add an EOF check for subblock I/O
>  - minor cleanups

  parent reply	other threads:[~2021-01-23 18:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 16:20 reduce sub-block DIO serialisation v4 Christoph Hellwig
2021-01-22 16:20 ` [PATCH 01/11] xfs: factor out a xfs_ilock_iocb helper Christoph Hellwig
2021-01-22 16:20 ` [PATCH 02/11] xfs: make xfs_file_aio_write_checks IOCB_NOWAIT-aware Christoph Hellwig
2021-01-22 16:20 ` [PATCH 03/11] xfs: cleanup the read/write helper naming Christoph Hellwig
2021-01-22 16:20 ` [PATCH 04/11] xfs: remove the buffered I/O fallback assert Christoph Hellwig
2021-01-22 16:20 ` [PATCH 05/11] xfs: simplify the read/write tracepoints Christoph Hellwig
2021-01-22 16:20 ` [PATCH 06/11] xfs: improve the reflink_bounce_dio_write tracepoint Christoph Hellwig
2021-01-22 16:20 ` [PATCH 07/11] xfs: split the unaligned DIO write code out Christoph Hellwig
2021-01-22 16:20 ` [PATCH 08/11] iomap: rename the flags variable in __iomap_dio_rw Christoph Hellwig
2021-01-22 16:20 ` [PATCH 09/11] iomap: pass a flags argument to iomap_dio_rw Christoph Hellwig
2021-01-22 16:20 ` [PATCH 10/11] iomap: add a IOMAP_DIO_OVERWRITE_ONLY flag Christoph Hellwig
2021-01-22 16:20 ` [PATCH 11/11] xfs: reduce exclusive locking on unaligned dio Christoph Hellwig
2021-01-22 17:24   ` Darrick J. Wong
2021-01-23 18:57 ` Darrick J. Wong [this message]
2021-02-01 16:58   ` reduce sub-block DIO serialisation v4 Christoph Hellwig
2021-02-01 17:51     ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210123185706.GG1282159@magnolia \
    --to=djwong@kernel.org \
    --cc=avi@scylladb.com \
    --cc=david@fromorbit.com \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).