linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kari Argillander <kari.argillander@gmail.com>
To: Mark Harmstone <mark@harmstone.com>
Cc: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
	linux-kernel@vger.kernel.org, pali@kernel.org, dsterba@suse.cz,
	aaptel@suse.com, willy@infradead.org, rdunlap@infradead.org,
	joe@perches.com, nborisov@suse.com,
	linux-ntfs-dev@lists.sourceforge.net, anton@tuxera.com,
	dan.carpenter@oracle.com, hch@lst.de, ebiggers@kernel.org,
	andy.lavr@gmail.com
Subject: Re: [PATCH v18 01/10] fs/ntfs3: Add headers and misc files
Date: Thu, 28 Jan 2021 09:05:41 +0200	[thread overview]
Message-ID: <20210128070541.ynzsgpniyo2xe23k@kari-VirtualBox> (raw)
In-Reply-To: <45515008-e4a9-26e3-3ce4-026bfacf7d53@harmstone.com>

On Fri, Jan 22, 2021 at 02:55:30PM +0000, Mark Harmstone wrote:
> On 22/1/21 2:01 pm, Konstantin Komarov wrote:
> > diff --git a/fs/ntfs3/upcase.c b/fs/ntfs3/upcase.c

> > +static inline u16 upcase_unicode_char(const u16 *upcase, u16 chr)
> > +{
> > +	if (chr < 'a')
> > +		return chr;
> > +
> > +	if (chr <= 'z')
> > +		return chr - ('a' - 'A');
> > +
> > +	return upcase[chr];
> > +}
> 
> Shouldn't upcase_unicode_char be using the NTFS pseudo-file $UpCase?
> That way you should also be covered for other bicameral alphabets.

return upcase[chr] is just for that? Upcase table from $UpCase is constucted
in super.c and this will get it in and use it.

  reply	other threads:[~2021-01-28  7:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22 14:01 [PATCH v18 00/10] NTFS read-write driver GPL implementation by Paragon Software Konstantin Komarov
2021-01-22 14:01 ` [PATCH v18 01/10] fs/ntfs3: Add headers and misc files Konstantin Komarov
2021-01-22 14:55   ` Mark Harmstone
2021-01-28  7:05     ` Kari Argillander [this message]
2021-01-22 14:01 ` [PATCH v18 02/10] fs/ntfs3: Add initialization of super block Konstantin Komarov
2021-01-22 14:01 ` [PATCH v18 03/10] fs/ntfs3: Add bitmap Konstantin Komarov
2021-01-22 14:01 ` [PATCH v18 04/10] fs/ntfs3: Add file operations and implementation Konstantin Komarov
2021-01-22 14:01 ` [PATCH v18 05/10] fs/ntfs3: Add attrib operations Konstantin Komarov
2021-01-22 14:01 ` [PATCH v18 06/10] fs/ntfs3: Add compression Konstantin Komarov
2021-01-22 14:01 ` [PATCH v18 07/10] fs/ntfs3: Add NTFS journal Konstantin Komarov
2021-01-22 14:01 ` [PATCH v18 08/10] fs/ntfs3: Add Kconfig, Makefile and doc Konstantin Komarov
2021-01-22 14:01 ` [PATCH v18 09/10] fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile Konstantin Komarov
2021-01-22 14:01 ` [PATCH v18 10/10] fs/ntfs3: Add MAINTAINERS Konstantin Komarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210128070541.ynzsgpniyo2xe23k@kari-VirtualBox \
    --to=kari.argillander@gmail.com \
    --cc=aaptel@suse.com \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=andy.lavr@gmail.com \
    --cc=anton@tuxera.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dsterba@suse.cz \
    --cc=ebiggers@kernel.org \
    --cc=hch@lst.de \
    --cc=joe@perches.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-ntfs-dev@lists.sourceforge.net \
    --cc=mark@harmstone.com \
    --cc=nborisov@suse.com \
    --cc=pali@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).