linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalesh Singh <kaleshsingh@google.com>
To: unlisted-recipients:; (no To-header on input)
Cc: jannh@google.com, jeffv@google.com, keescook@chromium.org,
	surenb@google.com, minchan@kernel.org, hridya@google.com,
	kernel-team@android.com, "Kalesh Singh" <kaleshsingh@google.com>,
	"Sumit Semwal" <sumit.semwal@linaro.org>,
	"Christian König" <christian.koenig@amd.com>,
	"Alexey Dobriyan" <adobriyan@gmail.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Alexey Gladkov" <gladkov.alexey@gmail.com>,
	"Daniel Jordan" <daniel.m.jordan@oracle.com>,
	"Michel Lespinasse" <walken@google.com>,
	"Bernd Edlinger" <bernd.edlinger@hotmail.de>,
	"Andrei Vagin" <avagin@gmail.com>,
	"Yafang Shao" <laoar.shao@gmail.com>,
	"Christian Brauner" <christian.brauner@ubuntu.com>,
	linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH 0/2] Allow reading process DMA buf stats from fdinfo
Date: Thu, 28 Jan 2021 18:24:29 +0000	[thread overview]
Message-ID: <20210128182432.2216573-1-kaleshsingh@google.com> (raw)

Android captures per-process system memory state when certain low memory
events (e.g a foreground app kill) occur, to identify potential memory
hoggers. In order to measure how much memory a process actually consumes,
it is necessary to include the DMA buffer sizes for that process in the
memory accounting. Since the handle to DMA buffers are raw FDs, it is
important to be able to identify which processes have FD references to
a DMA buffer.

Currently, DMA buffer FDs can be accounted using /proc/<pid>/fd/* and
/proc/<pid>/fdinfo -- both are only readable by the process owner,
as follows:
  1. Do a readlink on each FD.
  2. If the target path begins with "/dmabuf", then the FD is a dmabuf FD.
  3. stat the file to get the dmabuf inode number.
  4. Read/ proc/<pid>/fdinfo/<fd>, to get the DMA buffer size.

Accessing other processes’ fdinfo requires root privileges. This limits
the use of the interface to debugging environments and is not suitable
for production builds.  Granting root privileges even to a system process
increases the attack surface and is highly undesirable.

This series proposes making the requirement to read fdinfo less strict
with PTRACE_MODE_READ.


Kalesh Singh (2):
  procfs: Allow reading fdinfo with PTRACE_MODE_READ
  dmabuf: Add dmabuf inode no to fdinfo

 drivers/dma-buf/dma-buf.c |  1 +
 fs/proc/base.c            |  4 ++--
 fs/proc/fd.c              | 15 ++++++++++++++-
 3 files changed, 17 insertions(+), 3 deletions(-)

-- 
2.30.0.365.g02bc693789-goog


             reply	other threads:[~2021-01-28 18:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-28 18:24 Kalesh Singh [this message]
2021-01-28 18:24 ` [PATCH 1/2] procfs: Allow reading fdinfo with PTRACE_MODE_READ Kalesh Singh
2021-01-28 18:24 ` [PATCH 2/2] dmabuf: Add dmabuf inode no to fdinfo Kalesh Singh
2021-02-03 20:49 ` [PATCH 0/2] Allow reading process DMA buf stats from fdinfo Kalesh Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210128182432.2216573-1-kaleshsingh@google.com \
    --to=kaleshsingh@google.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=avagin@gmail.com \
    --cc=bernd.edlinger@hotmail.de \
    --cc=christian.brauner@ubuntu.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel.m.jordan@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ebiederm@xmission.com \
    --cc=gladkov.alexey@gmail.com \
    --cc=hridya@google.com \
    --cc=jannh@google.com \
    --cc=jeffv@google.com \
    --cc=keescook@chromium.org \
    --cc=kernel-team@android.com \
    --cc=laoar.shao@gmail.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=minchan@kernel.org \
    --cc=sumit.semwal@linaro.org \
    --cc=surenb@google.com \
    --cc=walken@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).