From: "Aurélien Aptel" <aaptel@suse.com>
To: linux-cifs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Cc: smfrench@gmail.com, Aurelien Aptel <aaptel@suse.com>,
Shyam Prasad N <nspmangalore@gmail.com>
Subject: [PATCH v2] cifs: report error instead of invalid when revalidating a dentry fails
Date: Tue, 2 Feb 2021 12:16:07 +0100 [thread overview]
Message-ID: <20210202111607.16372-1-aaptel@suse.com> (raw)
In-Reply-To: <CANT5p=oSrrCbCdXZSbjmPDM4P=z=1c=kj9w1DDTJO5UhtREo8g@mail.gmail.com>
From: Aurelien Aptel <aaptel@suse.com>
Assuming
- //HOST/a is mounted on /mnt
- //HOST/b is mounted on /mnt/b
On a slow connection, running 'df' and killing it while it's
processing /mnt/b can make cifs_get_inode_info() returns -ERESTARTSYS.
This triggers the following chain of events:
=> the dentry revalidation fail
=> dentry is put and released
=> superblock associated with the dentry is put
=> /mnt/b is unmounted
This patch makes cifs_d_revalidate() return the error instead of
0 (invalid) when cifs_revalidate_dentry() fails.
Signed-off-by: Aurelien Aptel <aaptel@suse.com>
Suggested-by: Shyam Prasad N <nspmangalore@gmail.com>
---
fs/cifs/dir.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c
index 68900f1629bff..4174f35590e62 100644
--- a/fs/cifs/dir.c
+++ b/fs/cifs/dir.c
@@ -737,6 +737,7 @@ static int
cifs_d_revalidate(struct dentry *direntry, unsigned int flags)
{
struct inode *inode;
+ int rc;
if (flags & LOOKUP_RCU)
return -ECHILD;
@@ -746,8 +747,11 @@ cifs_d_revalidate(struct dentry *direntry, unsigned int flags)
if ((flags & LOOKUP_REVAL) && !CIFS_CACHE_READ(CIFS_I(inode)))
CIFS_I(inode)->time = 0; /* force reval */
- if (cifs_revalidate_dentry(direntry))
- return 0;
+ rc = cifs_revalidate_dentry(direntry);
+ if (rc) {
+ cifs_dbg(FYI, "cifs_revalidate_dentry failed with rc=%d", rc);
+ return rc;
+ }
else {
/*
* If the inode wasn't known to be a dfs entry when
--
2.29.2
next prev parent reply other threads:[~2021-02-02 11:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 17:13 [PATCH v1] cifs: make nested cifs mount point dentries always valid to deal with signaled 'df' Aurélien Aptel
2021-01-31 9:28 ` Shyam Prasad N
2021-02-01 10:31 ` Aurélien Aptel
2021-02-01 16:51 ` Shyam Prasad N
2021-02-02 11:00 ` Aurélien Aptel
2021-02-02 11:16 ` Aurélien Aptel [this message]
2021-02-02 17:09 ` [PATCH v2] cifs: report error instead of invalid when revalidating a dentry fails Shyam Prasad N
2021-02-02 17:34 ` Aurélien Aptel
2021-02-02 17:42 ` [PATCH v3] " Aurélien Aptel
2021-02-02 18:26 ` Shyam Prasad N
2021-02-02 18:34 ` Aurélien Aptel
2021-02-03 4:24 ` Shyam Prasad N
2021-02-05 13:32 ` Shyam Prasad N
2021-02-05 14:42 ` [PATCH v4] " Aurélien Aptel
2021-02-05 14:52 ` Shyam Prasad N
2021-02-05 19:22 ` Steve French
2021-02-05 22:31 ` Steve French
2021-02-03 4:11 ` [PATCH v3] " Steve French
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202111607.16372-1-aaptel@suse.com \
--to=aaptel@suse.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).