From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FC1AC433E0 for ; Tue, 2 Feb 2021 19:33:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78D0D64E39 for ; Tue, 2 Feb 2021 19:33:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239851AbhBBTct (ORCPT ); Tue, 2 Feb 2021 14:32:49 -0500 Received: from mx2.suse.de ([195.135.220.15]:47240 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239707AbhBBTbc (ORCPT ); Tue, 2 Feb 2021 14:31:32 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E186FACD4; Tue, 2 Feb 2021 19:30:47 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id AC91DDA6FC; Tue, 2 Feb 2021 20:28:57 +0100 (CET) Date: Tue, 2 Feb 2021 20:28:57 +0100 From: David Sterba To: Johannes Thumshirn Cc: Naohiro Aota , "linux-btrfs@vger.kernel.org" , "dsterba@suse.com" , "hare@suse.com" , "linux-fsdevel@vger.kernel.org" , Jens Axboe , "hch@infradead.org" , "Darrick J. Wong" , Josef Bacik Subject: Re: [PATCH v14 32/42] btrfs: avoid async metadata checksum on ZONED mode Message-ID: <20210202192857.GZ1993@suse.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Johannes Thumshirn , Naohiro Aota , "linux-btrfs@vger.kernel.org" , "dsterba@suse.com" , "hare@suse.com" , "linux-fsdevel@vger.kernel.org" , Jens Axboe , "hch@infradead.org" , "Darrick J. Wong" , Josef Bacik References: <13728adcc4f433c928b00be73ea5466f62ccb4b9.1611627788.git.naohiro.aota@wdc.com> <20210202145418.GX1993@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Feb 02, 2021 at 04:50:26PM +0000, Johannes Thumshirn wrote: > On 02/02/2021 15:58, David Sterba wrote: > >> static int check_async_write(struct btrfs_fs_info *fs_info, > >> struct btrfs_inode *bi) > >> { > >> + if (btrfs_is_zoned(fs_info)) > >> + return 0; > > This check need to be after the other ones as zoned is a static per-fs > > status, while other others depend on either current state or system > > state (crypto implementation). > > > >> if (atomic_read(&bi->sync_writers)) > >> return 0; > >> if (test_bit(BTRFS_FS_CSUM_IMPL_FAST, &fs_info->flags)) > > Can you explain the reasoning behind that rule? For a non-zoned FS this won't > make a huge difference to check fs_info->zoned and for a zoned FS we're > bailing out fast as we can't support async checksums. On first sight it looked like a special case for zoned while it's not the major usecase but the test is cheap and fast, it's ok to keep it first.