From: Ira Weiny <ira.weiny@intel.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"linux-f2fs-devel@lists.sourceforge.net"
<linux-f2fs-devel@lists.sourceforge.net>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"tytso@mit.edu" <tytso@mit.edu>,
"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
"jaegeuk@kernel.org" <jaegeuk@kernel.org>,
"chao@kernel.org" <chao@kernel.org>,
Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"dongli.zhang@oracle.com" <dongli.zhang@oracle.com>,
"clm@fb.com" <clm@fb.com>, "dsterba@suse.com" <dsterba@suse.com>,
"ebiggers@kernel.org" <ebiggers@kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"dave.hansen@intel.com" <dave.hansen@intel.com>
Subject: Re: [RFC PATCH 0/8] use core page calls instead of kmaps
Date: Sun, 7 Feb 2021 20:42:05 -0800 [thread overview]
Message-ID: <20210208044205.GG5033@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <BYAPR04MB49655721C8EE8BAFF055EE2986B09@BYAPR04MB4965.namprd04.prod.outlook.com>
On Sun, Feb 07, 2021 at 07:10:41PM +0000, Chaitanya Kulkarni wrote:
> On 2/7/21 11:04, Chaitanya Kulkarni wrote:
> > Chaitanya Kulkarni (8):
> > brd: use memcpy_from_page() in copy_from_brd()
> > brd: use memcpy_from_page() in copy_from_brd()
> I'm aware that couple of places in brd code we can use memcpy_to_page()
> and get rid the local variable, once I get some feedback I'll add those
> to the V1.
Except for the one comment I had this series look's good to me.
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Thanks!
Ira
next prev parent reply other threads:[~2021-02-08 4:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 19:04 [RFC PATCH 0/8] use core page calls instead of kmaps Chaitanya Kulkarni
2021-02-07 19:04 ` [RFC PATCH 1/8] brd: use memcpy_from_page() in copy_from_brd() Chaitanya Kulkarni
2021-02-07 19:04 ` [RFC PATCH 2/8] " Chaitanya Kulkarni
2021-02-08 4:35 ` Ira Weiny
2021-02-08 5:47 ` Chaitanya Kulkarni
2021-02-07 19:04 ` [RFC PATCH 3/8] null_blk: use memcpy_page() in copy_to_nullb() Chaitanya Kulkarni
2021-02-07 19:04 ` [RFC PATCH 4/8] null_blk: use memcpy_page() in copy_from_nullb() Chaitanya Kulkarni
2021-02-07 19:04 ` [RFC PATCH 5/8] ext4: use memcpy_from_page() in pagecache_read() Chaitanya Kulkarni
2021-02-07 19:04 ` [RFC PATCH 6/8] ext4: use memcpy_to_page() in pagecache_write() Chaitanya Kulkarni
2021-03-25 14:22 ` Theodore Ts'o
2021-03-25 15:09 ` Ira Weiny
2021-03-25 15:10 ` Ira Weiny
2021-02-07 19:04 ` [RFC PATCH 7/8] f2fs: use memcpy_from_page() in pagecache_read() Chaitanya Kulkarni
2021-02-07 19:04 ` [RFC PATCH 8/8] f2fs: use memcpy_to_page() in pagecache_write() Chaitanya Kulkarni
2021-02-10 18:01 ` Eric Biggers
2021-02-10 19:41 ` Chaitanya Kulkarni
2021-02-07 19:10 ` [RFC PATCH 0/8] use core page calls instead of kmaps Chaitanya Kulkarni
2021-02-08 4:42 ` Ira Weiny [this message]
2021-02-08 5:47 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208044205.GG5033@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=adilger.kernel@dilger.ca \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chao@kernel.org \
--cc=clm@fb.com \
--cc=dave.hansen@intel.com \
--cc=dongli.zhang@oracle.com \
--cc=dsterba@suse.com \
--cc=ebiggers@kernel.org \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).