From: Jens Axboe <axboe@kernel.dk>
To: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Cc: akpm@linux-foundation.org
Subject: [PATCHSET v3 0/3] Improve IOCB_NOWAIT O_DIRECT reads
Date: Wed, 24 Feb 2021 09:44:52 -0700 [thread overview]
Message-ID: <20210224164455.1096727-1-axboe@kernel.dk> (raw)
Hi,
For v1, see:
https://lore.kernel.org/linux-fsdevel/20210208221829.17247-1-axboe@kernel.dk/
tldr; don't -EAGAIN IOCB_NOWAIT dio reads just because we have page cache
entries for the given range. This causes unnecessary work from the callers
side, when the IO could have been issued totally fine without blocking on
writeback when there is none.
fs/iomap/direct-io.c | 24 ++++++++++++++--------
include/linux/fs.h | 2 ++
mm/filemap.c | 47 ++++++++++++++++++++++++++++++++++++++++++--
3 files changed, 63 insertions(+), 10 deletions(-)
Andrew, any chance you can pick this up for 5.12?
Since v2:
- Drop overly long line (hch)
- Rebase to master, iomap changed flags to iomap_flags
--
Jens Axboe
next reply other threads:[~2021-02-24 16:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 16:44 Jens Axboe [this message]
2021-02-24 16:44 ` [PATCH 1/3] mm: provide filemap_range_needs_writeback() helper Jens Axboe
2021-02-24 16:50 ` Matthew Wilcox
2021-02-24 16:53 ` Jens Axboe
2021-02-24 17:22 ` Jan Kara
2021-02-24 16:44 ` [PATCH 2/3] mm: use filemap_range_needs_writeback() for O_DIRECT reads Jens Axboe
2021-02-24 16:57 ` Matthew Wilcox
2021-02-24 17:23 ` Jan Kara
2021-02-24 16:44 ` [PATCH 3/3] iomap: " Jens Axboe
2021-02-24 17:25 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224164455.1096727-1-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).