From: Christian Brauner <christian.brauner@ubuntu.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, Hugh Dickins <hughd@google.com>,
Theodore Tso <tytso@mit.edu>,
Damien Le Moal <damien.lemoal@wdc.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] fs: introduce a wrapper uuid_to_fsid()
Date: Tue, 23 Mar 2021 15:09:38 +0100 [thread overview]
Message-ID: <20210323140938.tv2ykukb7w7i66wp@wittgenstein> (raw)
In-Reply-To: <20210322173944.449469-2-amir73il@gmail.com>
On Mon, Mar 22, 2021 at 07:39:43PM +0200, Amir Goldstein wrote:
> Some filesystem's use a digest of their uuid for f_fsid.
> Create a simple wrapper for this open coded folding.
>
> Filesystems that have a non null uuid but use the block device
> number for f_fsid may also consider using this helper.
>
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> ---
Seen that as part of your other series yesterday. Looks like a good
improvement and removes a bunch of open-coding.
Reviewed-by: Christian Brauner <christian.brauner@ubuntu.com>
next prev parent reply other threads:[~2021-03-23 14:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 17:39 [PATCH 0/2] Better fanotify support for tmpfs Amir Goldstein
2021-03-22 17:39 ` [PATCH 1/2] fs: introduce a wrapper uuid_to_fsid() Amir Goldstein
2021-03-23 5:19 ` Damien Le Moal
2021-03-23 14:09 ` Christian Brauner [this message]
2021-03-22 17:39 ` [PATCH 2/2] shmem: allow reporting fanotify events with file handles on tmpfs Amir Goldstein
2021-03-25 15:00 ` Jan Kara
2021-04-16 9:59 ` Amir Goldstein
2021-04-17 3:54 ` Hugh Dickins
2021-04-19 8:34 ` Jan Kara
2021-03-23 13:25 ` [PATCH 0/2] Better fanotify support for tmpfs Jan Kara
2021-03-23 14:13 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210323140938.tv2ykukb7w7i66wp@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=amir73il@gmail.com \
--cc=damien.lemoal@wdc.com \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).