From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F374C43461 for ; Tue, 13 Apr 2021 20:43:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 736136113D for ; Tue, 13 Apr 2021 20:43:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348259AbhDMUna (ORCPT ); Tue, 13 Apr 2021 16:43:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:32945 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232101AbhDMUn3 (ORCPT ); Tue, 13 Apr 2021 16:43:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618346588; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l7+E0a1RmQtz9OdkPBWVwzVjeeLrb1IaJD410lr0Tlc=; b=fD0sYZLA3YodHgRIFQTQBHzMknKBGjWYWq7iX8NtN9lxtrlBjgVjEMyHc2hPkGrMW50EkW 6sEdZLb84o0EalDsAqrp3ldCzkSfIaj1X7Ep8NkC5Pw7sIZ0n74Ohu1p9YOYJ7a8lcgCDK GVm66+oZt3joLX/ygM5FNm7iHCtREXk= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-197-IDxx9R0LP7SswMUqV2SzNA-1; Tue, 13 Apr 2021 16:43:07 -0400 X-MC-Unique: IDxx9R0LP7SswMUqV2SzNA-1 Received: by mail-qk1-f200.google.com with SMTP id h21so11843993qkl.12 for ; Tue, 13 Apr 2021 13:43:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=l7+E0a1RmQtz9OdkPBWVwzVjeeLrb1IaJD410lr0Tlc=; b=MzS+P/I2RKfICO5mVZGARY/bXhu0DeHLZ/ytfv/AdNaVluSo8NN8j9oHzD6JWp+pE3 08CxTncAOu7/n/dEZuJ8uftRHtlKnGn/HvzUirhTOZtJnpa5tFz30yn5OTbw1ebxcbGj gqEMf5xuz/0BC7+icXDKDwJksNQTeoTQ2iQ6E/QZjFPw+JEh2YcMuv66hnlhO714GA6k YZgIKXmeE0j68bDLb8BVany6vxGrZeQBJoHRfSzmKBV4CCEhX3Pp19vkyWvZFX4N910Q lufBgPm7835DcA3ka/9IZRet3kPDSN5J+eNrCj3li0ABFEcDRcBzO2IBE1JtIQagyH1S QOvQ== X-Gm-Message-State: AOAM531kx4BIwgqNs0ZM7Frbg8HCVLg2hhRmbHT5x1LbXg6iS0yd9eOq l097akHXvGLUWC8Uij65oiDutKItCVP51T42LsoUZ7kxqeB0ChKkLhauXKJj+NeKZfYjvrUaXOM srlWT7RsHxc95IBMwqC2oFVHubg== X-Received: by 2002:ac8:529a:: with SMTP id s26mr9139700qtn.86.1618346586711; Tue, 13 Apr 2021 13:43:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhhgdT699IOjKyQMCFGRKWPZFD1wjCraEpotriSy8OLfP4IZ7xZ1qfAYCJAbXf3dGDou98CA== X-Received: by 2002:ac8:529a:: with SMTP id s26mr9139679qtn.86.1618346586512; Tue, 13 Apr 2021 13:43:06 -0700 (PDT) Received: from xz-x1 (bras-base-toroon474qw-grc-88-174-93-75-154.dsl.bell.ca. [174.93.75.154]) by smtp.gmail.com with ESMTPSA id i2sm3031068qtg.0.2021.04.13.13.43.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 13:43:05 -0700 (PDT) Date: Tue, 13 Apr 2021 16:43:04 -0400 From: Peter Xu To: Axel Rasmussen Cc: Alexander Viro , Andrea Arcangeli , Andrew Morton , Hugh Dickins , Jerome Glisse , Joe Perches , Lokesh Gidra , Mike Kravetz , Mike Rapoport , Shaohua Li , Shuah Khan , Stephen Rothwell , Wang Qing , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Brian Geffon , "Dr . David Alan Gilbert" , Mina Almasry , Oliver Upton Subject: Re: [PATCH v2 3/9] userfaultfd/shmem: support minor fault registration for shmem Message-ID: <20210413204304.GG4440@xz-x1> References: <20210413051721.2896915-1-axelrasmussen@google.com> <20210413051721.2896915-4-axelrasmussen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210413051721.2896915-4-axelrasmussen@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Apr 12, 2021 at 10:17:15PM -0700, Axel Rasmussen wrote: > This patch allows shmem-backed VMAs to be registered for minor faults. > Minor faults are appropriately relayed to userspace in the fault path, > for VMAs with the relevant flag. > > This commit doesn't hook up the UFFDIO_CONTINUE ioctl for shmem-backed > minor faults, though, so userspace doesn't yet have a way to resolve > such faults. > > Signed-off-by: Axel Rasmussen Everything looks right to me, but it'll be great if Andrea or Hugh will have a look too. Acked-by: Peter Xu -- Peter Xu