From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47C43C433ED for ; Mon, 19 Apr 2021 09:42:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C11D61157 for ; Mon, 19 Apr 2021 09:42:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238091AbhDSJnD (ORCPT ); Mon, 19 Apr 2021 05:43:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238510AbhDSJm7 (ORCPT ); Mon, 19 Apr 2021 05:42:59 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B68A0C06174A; Mon, 19 Apr 2021 02:42:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=5TJVXtI9X2kcptz9UBE/JvUwJanKZ4gbvYwSLMqz6T0=; b=V0/cr8zLKuJGdpCGbZew7airJL 46ipns0v+MwJUhsQBXTH+DZlRTHjocgl9d7jgveKVxfDJEyNaZoJjd1lXaNF00eZ/2CivzveEEHqw edPsPTmSI/imOc293tM3R3jGSDjJ2ntpCaOedZeyVjtEeWP6U6o+ofHOSkZB8PuqFvXlhkxLJInsQ kl9ZGgCHZGvV9HR9PMLxNlFP4fB0656W/wYNz8NGOGq05Ks/zT4Fn0rES1V+Tjly7p+RfeFNnruMs r9b+TZanWhZViH/3TCVgYaLIwZMOfugEyoq++Y2hFqZDGLZq1lDMMy6V8i9qCLBW27GcHz+v1IJI/ XAj1YZlw==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lYQNF-00DXWh-2b; Mon, 19 Apr 2021 09:39:47 +0000 Date: Mon, 19 Apr 2021 10:39:21 +0100 From: "hch@infradead.org" To: Damien Le Moal Cc: "hch@infradead.org" , "dsterba@suse.cz" , "dm-devel@redhat.com" , Mike Snitzer , "linux-block@vger.kernel.org" , Jens Axboe , "linux-nvme@lists.infradead.org" , Christoph Hellwig , "linux-scsi@vger.kernel.org" , "Martin K . Petersen" , "linux-fsdevel@vger.kernel.org" , "linux-btrfs@vger.kernel.org" , David Sterba , Josef Bacik , Johannes Thumshirn , Shinichiro Kawasaki , Naohiro Aota Subject: Re: [PATCH 3/4] btrfs: zoned: fail mount if the device does not support zone append Message-ID: <20210419093921.GA3226573@infradead.org> References: <20210416030528.757513-1-damien.lemoal@wdc.com> <20210416030528.757513-4-damien.lemoal@wdc.com> <20210416161720.GA7604@twin.jikos.cz> <20210419092855.GA3223318@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Apr 19, 2021 at 09:35:37AM +0000, Damien Le Moal wrote: > This is only to avoid someone from running zoned-btrfs on top of dm-crypt. > Without this patch, mount will be OK and file data writes will also actually be > OK. But all reads will miserably fail... I would rather have this patch in than > deal with the "bug reports" about btrfs failing to read files. No ? > > Note that like you, I dislike having to add such code. But it was my oversight > when I worked on getting dm-crypt to work on zoned drives. Zone append was > overlooked at that time... My bad, really. dm-crypt needs to stop pretending it supports zoned devices if it doesn't. Note that dm-crypt could fairly trivially support zone append by doing the same kind of emulation that the sd driver does.