From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06D20C433B4 for ; Tue, 20 Apr 2021 12:49:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8240613C7 for ; Tue, 20 Apr 2021 12:49:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231661AbhDTMtw (ORCPT ); Tue, 20 Apr 2021 08:49:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230408AbhDTMtu (ORCPT ); Tue, 20 Apr 2021 08:49:50 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D07E8C06174A; Tue, 20 Apr 2021 05:49:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UBs/3IU4qOqe26pmfSqrhN0agM0g3vHrn8n2VyPPRIA=; b=Cp8tD01wvbGNq/BTg28Lb+24q0 24nfSk4rkJykvYI8OV7ePARwDW8y3pbJDxTKxcyZl7CXUUDJkBV2GQWQIxT4lYugJINfq9bIqLJH6 pbP0y3i+ukb+uPu8rHGXLtGebC0wxoq7FP8da4zS53Jn/tWaCsSt1opwbRHjsrd81LycIBj9958YC 11NWXr32TwC/JbcLS1xgRm/wUNg/SZt9y/JF2YWjSB/SEHVGfK6YwAKITc2MeDVdR8AqnMY4DYp65 8Q/4sHztBrh7o5GMuQDP+xCHJorg7Jahxp61dMtl440AKp4j5SK57VhiZ9sIuCozrJpMBvLhpMi+M m/Cq4l1w==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lYplq-00FATl-EQ; Tue, 20 Apr 2021 12:47:19 +0000 Date: Tue, 20 Apr 2021 13:46:26 +0100 From: Christoph Hellwig To: Luis Chamberlain Cc: rafael@kernel.org, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, jack@suse.cz, bvanassche@acm.org, jeyu@kernel.org, ebiederm@xmission.com, mchehab@kernel.org, keescook@chromium.org, linux-fsdevel@vger.kernel.org, kernel@tuxforce.de, kexec@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC v2 4/6] fs: distinguish between user initiated freeze and kernel initiated freeze Message-ID: <20210420124626.GB3604224@infradead.org> References: <20210417001026.23858-1-mcgrof@kernel.org> <20210417001026.23858-5-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210417001026.23858-5-mcgrof@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Wouldn't it be simpler to just add a new flag to signal a kernel initiated freeze, or even better the exact reason (suspend) instead of overloading the state machine?