From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D86EC433ED for ; Wed, 21 Apr 2021 17:21:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F1206144E for ; Wed, 21 Apr 2021 17:21:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244664AbhDURWQ (ORCPT ); Wed, 21 Apr 2021 13:22:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:43851 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244724AbhDURWO (ORCPT ); Wed, 21 Apr 2021 13:22:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619025701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6JUDsCX1FVLABG3f9acRCoDqQKripe/7UMrZ2uGWSs8=; b=EJVoqZIFNgoM5y34vnrBKDVDc7yToT1SirQIl9K28DHItbmpCsQYtbcJYCq7/vzbP1CKVO RYuSaBTeYb5O9d+ZOqngIdlJ8xHOcNNg+rIX3N+dTSUqRDBR+ojKpbanG7xwzR/yuGyUYR UDBGpNkbtKSJ0PzhCMvuIYFy7SgT3jg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-601-faPE_qS1MgukzwLIDB8nzA-1; Wed, 21 Apr 2021 13:21:39 -0400 X-MC-Unique: faPE_qS1MgukzwLIDB8nzA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D630E107ACC7; Wed, 21 Apr 2021 17:21:37 +0000 (UTC) Received: from horse.redhat.com (ovpn-114-206.rdu2.redhat.com [10.10.114.206]) by smtp.corp.redhat.com (Postfix) with ESMTP id F165519D80; Wed, 21 Apr 2021 17:21:30 +0000 (UTC) Received: by horse.redhat.com (Postfix, from userid 10451) id 6EB69220BCF; Wed, 21 Apr 2021 13:21:30 -0400 (EDT) Date: Wed, 21 Apr 2021 13:21:30 -0400 From: Vivek Goyal To: Matthew Wilcox Cc: Jan Kara , linux-fsdevel@vger.kernel.org, dan.j.williams@intel.com, virtio-fs@redhat.com, slp@redhat.com, miklos@szeredi.hu, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] dax: Add an enum for specifying dax wakup mode Message-ID: <20210421172130.GE1579961@redhat.com> References: <20210419213636.1514816-1-vgoyal@redhat.com> <20210419213636.1514816-2-vgoyal@redhat.com> <20210421092440.GM8706@quack2.suse.cz> <20210421155631.GC1579961@redhat.com> <20210421161624.GJ3596236@casper.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210421161624.GJ3596236@casper.infradead.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Apr 21, 2021 at 05:16:24PM +0100, Matthew Wilcox wrote: > On Wed, Apr 21, 2021 at 11:56:31AM -0400, Vivek Goyal wrote: > > +/** > > + * enum dax_entry_wake_mode: waitqueue wakeup toggle > > s/toggle/behaviour/ ? Will do. > > > + * @WAKE_NEXT: wake only the first waiter in the waitqueue > > + * @WAKE_ALL: wake all waiters in the waitqueue > > + */ > > +enum dax_entry_wake_mode { > > + WAKE_NEXT, > > + WAKE_ALL, > > +}; > > + > > static wait_queue_head_t *dax_entry_waitqueue(struct xa_state *xas, > > void *entry, struct exceptional_entry_key *key) > > { > > @@ -182,7 +192,8 @@ static int wake_exceptional_entry_func(w > > * The important information it's conveying is whether the entry at > > * this index used to be a PMD entry. > > */ > > -static void dax_wake_entry(struct xa_state *xas, void *entry, bool wake_all) > > +static void dax_wake_entry(struct xa_state *xas, void *entry, > > + enum dax_entry_wake_mode mode) > > It's an awfully verbose name. 'dax_wake_mode'? Sure. Will change. Vivek >