From: Richard Guy Briggs <rgb@redhat.com>
To: Christian Brauner <brauner@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Aleksa Sarai <cyphar@cyphar.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
Christian Brauner <christian.brauner@ubuntu.com>
Subject: Re: [PATCH 1/3] fcntl: remove unused VALID_UPGRADE_FLAGS
Date: Fri, 23 Apr 2021 08:36:26 -0400 [thread overview]
Message-ID: <20210423123626.GL3141668@madcap2.tricolour.ca> (raw)
In-Reply-To: <20210423111037.3590242-1-brauner@kernel.org>
On 2021-04-23 13:10, Christian Brauner wrote:
> From: Christian Brauner <christian.brauner@ubuntu.com>
>
> We currently do not maky use of this feature and should we implement
> something like this in the future it's trivial to add it back.
>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Aleksa Sarai <cyphar@cyphar.com>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: linux-fsdevel@vger.kernel.org
> Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Suggested-by: Richard Guy Briggs <rgb@redhat.com>
Reviewed-by: Richard Guy Briggs <rgb@redhat.com>
> ---
> include/linux/fcntl.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/include/linux/fcntl.h b/include/linux/fcntl.h
> index 766fcd973beb..a332e79b3207 100644
> --- a/include/linux/fcntl.h
> +++ b/include/linux/fcntl.h
> @@ -12,10 +12,6 @@
> FASYNC | O_DIRECT | O_LARGEFILE | O_DIRECTORY | O_NOFOLLOW | \
> O_NOATIME | O_CLOEXEC | O_PATH | __O_TMPFILE)
>
> -/* List of all valid flags for the how->upgrade_mask argument: */
> -#define VALID_UPGRADE_FLAGS \
> - (UPGRADE_NOWRITE | UPGRADE_NOREAD)
> -
> /* List of all valid flags for the how->resolve argument: */
> #define VALID_RESOLVE_FLAGS \
> (RESOLVE_NO_XDEV | RESOLVE_NO_MAGICLINKS | RESOLVE_NO_SYMLINKS | \
>
> base-commit: d434405aaab7d0ebc516b68a8fc4100922d7f5ef
> --
> 2.27.0
>
- RGB
--
Richard Guy Briggs <rgb@redhat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635
next prev parent reply other threads:[~2021-04-23 12:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 11:10 [PATCH 1/3] fcntl: remove unused VALID_UPGRADE_FLAGS Christian Brauner
2021-04-23 11:10 ` [PATCH 2/3] open: don't silently ignore unknown O-flags in openat2() Christian Brauner
2021-04-23 13:50 ` Richard Guy Briggs
2021-04-26 13:34 ` Christoph Hellwig
2021-05-01 0:53 ` Aleksa Sarai
2021-04-23 11:10 ` [PATCH 3/3] test: add openat2() test for invalid upper 32 bit flag value Christian Brauner
2021-04-30 15:24 ` Richard Guy Briggs
2021-04-30 16:09 ` Christian Brauner
2021-04-30 16:46 ` Richard Guy Briggs
2021-04-30 17:08 ` Christian Brauner
2021-04-30 17:22 ` Richard Guy Briggs
2021-04-23 12:36 ` Richard Guy Briggs [this message]
2021-04-26 13:33 ` [PATCH 1/3] fcntl: remove unused VALID_UPGRADE_FLAGS Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210423123626.GL3141668@madcap2.tricolour.ca \
--to=rgb@redhat.com \
--cc=brauner@kernel.org \
--cc=christian.brauner@ubuntu.com \
--cc=cyphar@cyphar.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).