From: Andrew Morton <firstname.lastname@example.org> To: chukaiping <email@example.com> Cc: firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, Mel Gorman <email@example.com>, David Rientjes <firstname.lastname@example.org> Subject: Re: [PATCH v4] mm/compaction: let proactive compaction order configurable Date: Sun, 9 May 2021 17:17:48 -0700 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> On Wed, 28 Apr 2021 10:28:21 +0800 chukaiping <email@example.com> wrote: > Currently the proactive compaction order is fixed to > COMPACTION_HPAGE_ORDER(9), it's OK in most machines with lots of > normal 4KB memory, but it's too high for the machines with small > normal memory, for example the machines with most memory configured > as 1GB hugetlbfs huge pages. In these machines the max order of > free pages is often below 9, and it's always below 9 even with hard > compaction. This will lead to proactive compaction be triggered very > frequently. In these machines we only care about order of 3 or 4. > This patch export the oder to proc and let it configurable > by user, and the default value is still COMPACTION_HPAGE_ORDER. It would be great to do this automatically? It's quite simple to see when memory is being handed out to hugetlbfs - so can we tune proactive_compaction_order in response to this? That would be far better than adding a manual tunable. But from having read Khalid's comments, that does sound quite involved. Is there some partial solution that we can come up with that will get most people out of trouble? That being said, this patch is super-super-simple so perhaps we should just merge it just to get one person (and hopefully a few more) out of trouble. But on the other hand, once we add a /proc tunable we must maintain that tunable for ever (or at least a very long time) even if the internal implementations change a lot.
next prev parent reply other threads:[~2021-05-10 0:17 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-28 2:28 chukaiping 2021-05-10 0:17 ` Andrew Morton [this message] 2021-05-10 2:10 ` 答复: " Chu,Kaiping 2021-05-11 4:20 ` David Rientjes 2021-05-28 17:42 ` Vlastimil Babka 2021-06-01 1:15 ` 答复: " Chu,Kaiping 2021-06-16 13:49 ` Vlastimil Babka 2021-06-09 10:44 ` David Hildenbrand 2021-06-15 1:11 ` 答复: " Chu,Kaiping 2021-06-15 8:04 ` David Hildenbrand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH v4] mm/compaction: let proactive compaction order configurable' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).