From: Ira Weiny <ira.weiny@intel.com>
To: Dan Williams <dan.j.williams@intel.com>,
Miklos Szeredi <miklos@szeredi.hu>
Cc: Vishal Verma <vishal.l.verma@intel.com>,
linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/3] fs/fuse: Remove unneeded kaddr parameter
Date: Fri, 11 Jun 2021 10:23:01 -0700 [thread overview]
Message-ID: <20210611172301.GA1600546@iweiny-DESK2.sc.intel.com> (raw)
In-Reply-To: <20210525172428.3634316-2-ira.weiny@intel.com>
On Tue, May 25, 2021 at 10:24:26AM -0700, 'Ira Weiny' wrote:
> From: Ira Weiny <ira.weiny@intel.com>
>
> fuse_dax_mem_range_init() does not need the address or the pfn of the
> memory requested in dax_direct_access(). It is only calling direct
> access to get the number of pages.
In looking for feedback on this small series I realize that I failed to email
Miklos for the fs/fuse patch.
I'm adding Miklos to the To line...
For the rest of the series is there any feedback?
Ira
>
> Remove the unused variables and stop requesting the kaddr and pfn from
> dax_direct_access().
>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> ---
> fs/fuse/dax.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/fuse/dax.c b/fs/fuse/dax.c
> index ff99ab2a3c43..34f8a5635c7f 100644
> --- a/fs/fuse/dax.c
> +++ b/fs/fuse/dax.c
> @@ -1234,8 +1234,6 @@ void fuse_dax_conn_free(struct fuse_conn *fc)
> static int fuse_dax_mem_range_init(struct fuse_conn_dax *fcd)
> {
> long nr_pages, nr_ranges;
> - void *kaddr;
> - pfn_t pfn;
> struct fuse_dax_mapping *range;
> int ret, id;
> size_t dax_size = -1;
> @@ -1247,8 +1245,8 @@ static int fuse_dax_mem_range_init(struct fuse_conn_dax *fcd)
> INIT_DELAYED_WORK(&fcd->free_work, fuse_dax_free_mem_worker);
>
> id = dax_read_lock();
> - nr_pages = dax_direct_access(fcd->dev, 0, PHYS_PFN(dax_size), &kaddr,
> - &pfn);
> + nr_pages = dax_direct_access(fcd->dev, 0, PHYS_PFN(dax_size), NULL,
> + NULL);
> dax_read_unlock(id);
> if (nr_pages < 0) {
> pr_debug("dax_direct_access() returned %ld\n", nr_pages);
> --
> 2.28.0.rc0.12.gb6a658bd00c9
>
next prev parent reply other threads:[~2021-06-11 17:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 17:24 [PATCH 0/3] DAX Small clean ups ira.weiny
2021-05-25 17:24 ` [PATCH 1/3] fs/fuse: Remove unneeded kaddr parameter ira.weiny
2021-06-11 17:23 ` Ira Weiny [this message]
2021-06-18 7:01 ` Miklos Szeredi
2021-06-18 12:49 ` Vivek Goyal
2021-05-25 17:24 ` [PATCH 2/3] fs/dax: Clarify nr_pages to dax_direct_access() ira.weiny
2021-05-25 17:24 ` [PATCH 3/3] dax: Ensure errno is returned from dax_direct_access ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210611172301.GA1600546@iweiny-DESK2.sc.intel.com \
--to=ira.weiny@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=miklos@szeredi.hu \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).