From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6288CC2B9F4 for ; Mon, 14 Jun 2021 10:03:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3A561611BE for ; Mon, 14 Jun 2021 10:03:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232738AbhFNKFk (ORCPT ); Mon, 14 Jun 2021 06:05:40 -0400 Received: from verein.lst.de ([213.95.11.211]:43440 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232579AbhFNKFj (ORCPT ); Mon, 14 Jun 2021 06:05:39 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id C9C1368AFE; Mon, 14 Jun 2021 12:03:34 +0200 (CEST) Date: Mon, 14 Jun 2021 12:03:34 +0200 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , Andrew Morton , Al Viro , Greg Kroah-Hartman , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mm: require ->set_page_dirty to be explicitly wire up Message-ID: <20210614100334.GA10629@lst.de> References: <20210614061512.3966143-1-hch@lst.de> <20210614061512.3966143-4-hch@lst.de> <20210614095107.GD26615@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210614095107.GD26615@quack2.suse.cz> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jun 14, 2021 at 11:51:07AM +0200, Jan Kara wrote: > On Mon 14-06-21 08:15:12, Christoph Hellwig wrote: > > Remove the CONFIG_BLOCK default to __set_page_dirty_buffers and just > > wire that method up for the missing instances. > > > > Signed-off-by: Christoph Hellwig > > Make sense. Did you somehow autogenerate this? If this patch would race > with addition of new aops struct, we'd get null-ptr-defer out of that so > maybe providing the script would be better. But other than that the changes > look good to me. You can add: No, this was done manually as I audited all instances for actually being able to dirty pages.