linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jan Kara <jack@suse.cz>, Al Viro <viro@zeniv.linux.org.uk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: remove the implicit .set_page_dirty default
Date: Mon, 14 Jun 2021 17:55:30 +0200	[thread overview]
Message-ID: <20210614155530.GA2563@lst.de> (raw)
In-Reply-To: <20210614155333.GB2413@lst.de>

On Mon, Jun 14, 2021 at 05:53:33PM +0200, Christoph Hellwig wrote:
> On Mon, Jun 14, 2021 at 01:23:22PM +0100, Matthew Wilcox wrote:
> > i have a somewhat similar series in the works ...
> > 
> > https://git.infradead.org/users/willy/pagecache.git/commitdiff/1e7e8c2d82666b55690705d5bbe908e31d437edb
> > https://git.infradead.org/users/willy/pagecache.git/commitdiff/bf767a4969c0bc6735275ff7457a8082eef4c3fd
> > 
> > ... the other patches rather depend on the folio work.
> 
> Yes, these looks useful to me as well.


And in fact I suspect the code in __set_page_dirty_no_writeback should
really be the default if no ->set_page_dirty is set up.  It is the
same code as the no-mapping case and really makes sense as the default
case..

  reply	other threads:[~2021-06-14 15:55 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14  6:15 remove the implicit .set_page_dirty default Christoph Hellwig
2021-06-14  6:15 ` [PATCH 1/3] fs: unexport __set_page_dirty Christoph Hellwig
2021-06-14  6:23   ` Greg Kroah-Hartman
2021-06-14  9:42   ` Jan Kara
2021-06-14 12:32   ` Matthew Wilcox
2021-06-14 15:52     ` Christoph Hellwig
2021-06-14  6:15 ` [PATCH 2/3] fs: move ramfs_aops to libfs Christoph Hellwig
2021-06-14  6:24   ` Greg Kroah-Hartman
2021-06-14  9:45   ` Jan Kara
2021-06-14  6:15 ` [PATCH 3/3] mm: require ->set_page_dirty to be explicitly wire up Christoph Hellwig
2021-06-14  6:24   ` Greg Kroah-Hartman
2021-06-14  9:51   ` Jan Kara
2021-06-14 10:03     ` Christoph Hellwig
2021-06-18 19:23   ` Dmitry Osipenko
2021-06-21  5:26     ` Christoph Hellwig
2021-06-14 12:23 ` remove the implicit .set_page_dirty default Matthew Wilcox
2021-06-14 15:53   ` Christoph Hellwig
2021-06-14 15:55     ` Christoph Hellwig [this message]
2021-06-14 16:17       ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210614155530.GA2563@lst.de \
    --to=hch@lst.de \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).